Issue 8539007: Print out the ui_test test case in the reports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8539007: Print out the ui_test test case in the reports (Closed)

Created:
9 years, 1 month ago by Timur Iskhodzhanov

Modified:
9 years, 1 month ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Print out the ui_test test case in the reports TEST=ran memcheck and tsan locally on RedirectTest.Server with suppression files removed Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109602

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -12 lines)			Patch
M	tools/valgrind/memcheck_analyze.py	View	7 chunks	+9 lines, -4 lines	0 comments	Download
M	tools/valgrind/tsan_analyze.py	View	4 chunks	+7 lines, -2 lines	1 comment	Download
M	tools/valgrind/valgrind_test.py	View	4 chunks	+22 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

9 years, 1 month ago (2011-11-11 09:41:30 UTC) #2

LGTM with one nit

http://codereview.chromium.org/8539007/diff/1/tools/valgrind/tsan_analyze.py
File tools/valgrind/tsan_analyze.py (right):

http://codereview.chromium.org/8539007/diff/1/tools/valgrind/tsan_analyze.py#...
tools/valgrind/tsan_analyze.py:229: self._cur_testcase = None
Please add a comment describing why you need to reset _cur_testcase

Expand Messages | Collapse Messages