Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8539006: Cleanup: Remove unneeded forward declarations from various chrome/browser subdirectories. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, creis+watch_chromium.org, ajwong+watch_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., Avi (use Gerrit), James Su, dhollowa
Visibility:
Public.

Description

Cleanup: Remove unneeded forward declarations from various chrome/browser subdirectories. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109987

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -111 lines) Patch
M chrome/browser/autocomplete/autocomplete.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/history_provider.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.h View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_provider.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_extension_api.h View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/download/download_request_infobar_delegate.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/download/download_throttling_resource_handler.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_util.h View 1 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/google/google_url_tracker.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/intents/register_intent_handler_infobar_delegate.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/field_trial_synchronizer.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/metrics/metrics_log.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/net/net_pref_observer.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/notifications/balloon.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/balloon_host.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/notifications/notification_object_proxy.h View 1 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/notifications/notification_ui_manager.h View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_service_mock_builder.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_value_store.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/offline_resource_handler.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_views.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_cache.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_history.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.h View 1 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/search_engines/template_url.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/simple_alert_infobar_delegate.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/spelling_menu_observer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/web_applications/web_app.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/webdata/autocomplete_syncable_service.h View 1 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/webdata/keyword_table.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/webdata/web_intents_table.h View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
9 years, 1 month ago (2011-11-11 10:14:27 UTC) #1
eroman
lgtm
9 years, 1 month ago (2011-11-14 20:26:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8539006/1
9 years, 1 month ago (2011-11-14 22:48:58 UTC) #3
commit-bot: I haz the power
Can't apply patch for file chrome/browser/intents/register_intent_handler_infobar_delegate.h. While running patch -p0 --forward --force; patching file chrome/browser/intents/register_intent_handler_infobar_delegate.h ...
9 years, 1 month ago (2011-11-14 22:49:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8539006/11001
9 years, 1 month ago (2011-11-14 22:53:20 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 00:09:26 UTC) #6 
Change committed as 109987

Powered by Google App Engine
This is Rietveld 408576698