Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1475)

Unified Diff: chrome/browser/content_settings/content_settings_provider.h

Issue 8539004: Replace SetContentSetting method of the content_settings::Provider interface with GetWebsiteSetting (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase onto origin/trunk Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_provider.h
diff --git a/chrome/browser/content_settings/content_settings_provider.h b/chrome/browser/content_settings/content_settings_provider.h
index 48a554a71b86b5b04601d83cd9ed53fdb3d2f91d..1ec08511b5447000122530d7e7b62a14d3f25775 100644
--- a/chrome/browser/content_settings/content_settings_provider.h
+++ b/chrome/browser/content_settings/content_settings_provider.h
@@ -42,19 +42,20 @@ class ProviderInterface {
const ResourceIdentifier& resource_identifier,
bool incognito) const = 0;
- // Sets the content setting for a particular |primary_pattern|,
- // |secondary_pattern|, |content_type| tuple. For ContentSettingsTypes that
- // require a resource identifier to be specified, the |resource_identifier|
- // must be non-empty.
+ // Askes the provider to set the website setting for a particular
+ // |primary_pattern|, |secondary_pattern|, |content_type| tuple. If the
+ // provider accepts the setting it returns true and takes the ownership of the
+ // |value|. Otherwise false is returned and the ownership of the |value| stays
+ // with the caller.
//
// This should only be called on the UI thread, and not after
// ShutdownOnUIThread has been called.
- virtual void SetContentSetting(
+ virtual bool SetWebsiteSetting(
const ContentSettingsPattern& primary_pattern,
const ContentSettingsPattern& secondary_pattern,
ContentSettingsType content_type,
const ResourceIdentifier& resource_identifier,
- ContentSetting content_setting) = 0;
+ Value* value) = 0;
// Resets all content settings for the given |content_type| and empty resource
// identifier to CONTENT_SETTING_DEFAULT.

Powered by Google App Engine
This is Rietveld 408576698