Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: chrome/browser/extensions/extension_content_settings_api.cc

Issue 8539004: Replace SetContentSetting method of the content_settings::Provider interface with GetWebsiteSetting (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_content_settings_api.cc
diff --git a/chrome/browser/extensions/extension_content_settings_api.cc b/chrome/browser/extensions/extension_content_settings_api.cc
index 859306f25d6c78ce9534ad94df8f8e59a3f657f2..fbab528a9fb8b0888095d17897f57cd9d99b5211 100644
--- a/chrome/browser/extensions/extension_content_settings_api.cc
+++ b/chrome/browser/extensions/extension_content_settings_api.cc
@@ -10,6 +10,7 @@
#include "base/command_line.h"
#include "base/values.h"
#include "chrome/browser/content_settings/cookie_settings.h"
+#include "chrome/browser/content_settings/content_settings_utils.h"
#include "chrome/browser/content_settings/host_content_settings_map.h"
#include "chrome/browser/extensions/extension_content_settings_api_constants.h"
#include "chrome/browser/extensions/extension_content_settings_helpers.h"
@@ -154,8 +155,10 @@ bool GetContentSettingFunction::RunImpl() {
setting = cookie_settings->GetCookieSetting(primary_url, secondary_url,
setting_cookie, NULL);
} else {
- setting = map->GetContentSetting(primary_url, secondary_url, content_type,
- resource_identifier);
+ scoped_ptr<base::Value> value(
Bernhard Bauer 2011/11/11 14:00:40 Why this change? GetContentSetting is still availa
markusheintz_ 2011/11/14 11:15:10 Originally I planed to rm the SetContentSetting me
+ map->GetWebsiteSetting(primary_url, secondary_url, content_type,
+ resource_identifier, NULL));
+ setting = content_settings::ValueToContentSetting(value.get());
}
DictionaryValue* result = new DictionaryValue();

Powered by Google App Engine
This is Rietveld 408576698