Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4255)

Unified Diff: chrome/browser/content_settings/content_settings_provider.h

Issue 8539004: Replace SetContentSetting method of the content_settings::Provider interface with GetWebsiteSetting (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_provider.h
diff --git a/chrome/browser/content_settings/content_settings_provider.h b/chrome/browser/content_settings/content_settings_provider.h
index 745937024b4e15422a2d4f70df43dd2a17d25ea6..07adbda33e0fd9b536676b9d577dbfe432a7403b 100644
--- a/chrome/browser/content_settings/content_settings_provider.h
+++ b/chrome/browser/content_settings/content_settings_provider.h
@@ -43,19 +43,20 @@ class ProviderInterface {
const ResourceIdentifier& resource_identifier,
bool incognito) const = 0;
- // Sets the content setting for a particular |primary_pattern|,
+ // Sets the website setting for a particular |primary_pattern|,
// |secondary_pattern|, |content_type| tuple. For ContentSettingsTypes that
// require a resource identifier to be specified, the |resource_identifier|
- // must be non-empty.
+ // must be non-empty. The ownership of the passed |value| remains with the
+ // caller. Provider copy the passed |value|.
Bernhard Bauer 2011/11/11 14:00:40 The last sentence is unnecessary (what the provide
markusheintz_ 2011/11/14 11:15:10 Done.
//
// This should only be called on the UI thread, and not after
// ShutdownOnUIThread has been called.
- virtual void SetContentSetting(
+ virtual void SetWebsiteSetting(
const ContentSettingsPattern& primary_pattern,
const ContentSettingsPattern& secondary_pattern,
ContentSettingsType content_type,
const ResourceIdentifier& resource_identifier,
- ContentSetting content_setting) = 0;
+ const Value* value) = 0;
// Resets all content settings for the given |content_type| and empty resource
// identifier to CONTENT_SETTING_DEFAULT.

Powered by Google App Engine
This is Rietveld 408576698