Chromium Code Reviews| Index: chrome/browser/content_settings/content_settings_provider.h |
| diff --git a/chrome/browser/content_settings/content_settings_provider.h b/chrome/browser/content_settings/content_settings_provider.h |
| index 745937024b4e15422a2d4f70df43dd2a17d25ea6..4525befd06e2347c86e5dc1a2f1639dbb707f844 100644 |
| --- a/chrome/browser/content_settings/content_settings_provider.h |
| +++ b/chrome/browser/content_settings/content_settings_provider.h |
| @@ -43,19 +43,21 @@ class ProviderInterface { |
| const ResourceIdentifier& resource_identifier, |
| bool incognito) const = 0; |
| - // Sets the content setting for a particular |primary_pattern|, |
| - // |secondary_pattern|, |content_type| tuple. For ContentSettingsTypes that |
| - // require a resource identifier to be specified, the |resource_identifier| |
| - // must be non-empty. |
| + // Askes the provider to set the website setting for a particular |
| + // |primary_pattern|, |secondary_pattern|, |content_type| tuple. For |
| + // ContentSettingsTypes that require a resource identifier to be specified, |
| + // the |resource_identifier| must be non-empty. If the provider accepts the |
|
Bernhard Bauer
2011/11/15 15:40:28
The part about requiring a resource identifier is
markusheintz_
2011/11/15 17:36:58
Done.
|
| + // setting it returns true and takes the ownership of the |value|. Otherwise |
| + // false is returned and the ownership of the |value| stays with the caller. |
| // |
| // This should only be called on the UI thread, and not after |
| // ShutdownOnUIThread has been called. |
| - virtual void SetContentSetting( |
| + virtual bool SetWebsiteSetting( |
| const ContentSettingsPattern& primary_pattern, |
| const ContentSettingsPattern& secondary_pattern, |
| ContentSettingsType content_type, |
| const ResourceIdentifier& resource_identifier, |
| - ContentSetting content_setting) = 0; |
| + Value* value) = 0; |
| // Resets all content settings for the given |content_type| and empty resource |
| // identifier to CONTENT_SETTING_DEFAULT. |