Issue 8538038: Add values to all (non-dev, non-private) Pepper .idl enumerations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8538038: Add values to all (non-dev, non-private) Pepper .idl enumerations. (Closed)

Created:
9 years, 1 month ago by viettrungluu

Modified:
9 years, 1 month ago

Reviewers:
dmichael (off chromium), noelallen1

CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add values to all (non-dev, non-private) Pepper .idl enumerations. This reduces the warnings when running the generator and makes the definitions more robust (or at least makes it more obvious when someone changes things). TBR=dmichael@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109817

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -72 lines)			Patch
M	ppapi/api/pp_file_info.idl	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	ppapi/api/pp_var.idl	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	ppapi/api/ppb_url_request_info.idl	View	13 chunks	+13 lines, -13 lines	0 comments	Download
M	ppapi/api/ppb_url_response_info.idl	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	ppapi/c/pp_file_info.h	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	ppapi/c/pp_var.h	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	ppapi/c/ppb_url_request_info.h	View	11 chunks	+14 lines, -14 lines	0 comments	Download
M	ppapi/c/ppb_url_response_info.h	View	6 chunks	+7 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

viettrungluu

You should probably carefully check that I can count.

9 years, 1 month ago (2011-11-12 04:02:11 UTC) #1

noelallen1

9 years, 1 month ago (2011-11-13 00:23:40 UTC) #2

Your internal increment function appears to be working.
LGTM