Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: chrome/browser/ui/panels/panel_browser_view_browsertest.cc

Issue 8538032: Keep panel manager internal titlebar state consistent with changes to titlebars. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/panels/panel_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_browser_view_browsertest.cc
diff --git a/chrome/browser/ui/panels/panel_browser_view_browsertest.cc b/chrome/browser/ui/panels/panel_browser_view_browsertest.cc
index 83b1813bb67f6ca94080c0b4790088814ceab479..a90decd7e962f9e1875e9ef65ceaaebffb9b30a4 100644
--- a/chrome/browser/ui/panels/panel_browser_view_browsertest.cc
+++ b/chrome/browser/ui/panels/panel_browser_view_browsertest.cc
@@ -242,11 +242,6 @@ class PanelBrowserViewTest : public BasePanelBrowserTest {
EXPECT_EQ(Panel::MINIMIZED, panel3->expansion_state());
EXPECT_EQ(2, panel_manager->minimized_panel_count());
- // TODO(dimich): Either remove this test in favor of platform-independent
- // one, or fix it. It is broken because are_titlebars_up_ in PanelManager
- // is not in sync with requested state of titlebars.
- // http://crbug.com/102733
-/*
mock_auto_hiding_desktop_bar()->SetVisibility(
AutoHidingDesktopBar::ALIGN_BOTTOM, AutoHidingDesktopBar::VISIBLE);
panel_manager->BringUpOrDownTitlebars(true);
@@ -264,7 +259,6 @@ class PanelBrowserViewTest : public BasePanelBrowserTest {
EXPECT_EQ(Panel::EXPANDED, panel2->expansion_state());
EXPECT_EQ(Panel::MINIMIZED, panel3->expansion_state());
EXPECT_EQ(2, panel_manager->minimized_panel_count());
-*/
// Test if it is OK to bring up title-bar given the mouse position.
EXPECT_TRUE(panel_manager->ShouldBringUpTitlebars(
« no previous file with comments | « no previous file | chrome/browser/ui/panels/panel_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698