Issue 8538032: Keep panel manager internal titlebar state consistent with changes to titlebars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8538032: Keep panel manager internal titlebar state consistent with changes to titlebars. (Closed)

Created:
9 years, 1 month ago by jennb

Modified:
9 years, 1 month ago

Reviewers:
Dmitry Titov

CC:
chromium-reviews, jennb, prasadt, jianli, dcheng, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Keep panel manager internal titlebar state consistent with changes to titlebars. BUG=102733 TEST=PanelBrowserViewTest.MinimizeAndRestoreOn*TaskBar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109936

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -9 lines)			Patch
	M	chrome/browser/ui/panels/panel_browser_view_browsertest.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
	M	chrome/browser/ui/panels/panel_manager.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jennb

Try job results: http://build.chromium.org/p/tryserver.chromium/builders/win/builds/2734 http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/2496 http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/2437

9 years, 1 month ago (2011-11-12 01:40:57 UTC) #1

Dmitry Titov

LGTM! Nice, it took me longer to write that comment :-)

9 years, 1 month ago (2011-11-12 23:27:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennb@chromium.org/8538032/1

9 years, 1 month ago (2011-11-14 18:34:06 UTC) #3

Change committed as 109936

Expand Messages | Collapse Messages