Issue 8538018: Added a unittest for compositor observers.

Issue 8538018: Added a unittest for compositor observers. (Closed)

Created:
9 years, 1 month ago by Ian Vollick

Modified:
9 years, 1 month ago

Reviewers:
backer, jonathan.backer, piman

CC:
chromium-reviews, piman+watch_chromium.org, jonathan.backer, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added a unittest for compositor observers. Passes with both the browser and WebKit compositor. BUG=None TEST=compositor_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110242

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address reviewer comments. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -0 lines)			Patch
	M	ui/gfx/compositor/layer_unittest.cc	View	1	4 chunks	+90 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jonathan.backer

http://codereview.chromium.org/8538018/diff/1/ui/gfx/compositor/layer_unittest.cc File ui/gfx/compositor/layer_unittest.cc (right): http://codereview.chromium.org/8538018/diff/1/ui/gfx/compositor/layer_unittest.cc#newcode190 ui/gfx/compositor/layer_unittest.cc:190: bool notified_; DISALLOW_COPY_AND_ASSIGN http://codereview.chromium.org/8538018/diff/1/ui/gfx/compositor/layer_unittest.cc#newcode882 ui/gfx/compositor/layer_unittest.cc:882: GetCompositor()->RemoveObserver(&observer); Test this?

9 years, 1 month ago (2011-11-11 20:17:16 UTC) #3

Ian Vollick

On 2011/11/11 20:17:16, jonathan.backer wrote: > http://codereview.chromium.org/8538018/diff/1/ui/gfx/compositor/layer_unittest.cc > File ui/gfx/compositor/layer_unittest.cc (right): > > http://codereview.chromium.org/8538018/diff/1/ui/gfx/compositor/layer_unittest.cc#newcode190 > ...

9 years, 1 month ago (2011-11-11 20:23:03 UTC) #4

lgtm

Expand Messages | Collapse Messages