Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Issue 8538011: Reapply "Add a level of indirection to exception handler addresses." (Closed)

Created:
9 years, 1 month ago by Kevin Millikin (Chromium)
Modified:
9 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Reapply "Add a level of indirection to exception handler addresses." Original commit message: Add a level of indirection to exception handler addresses. To support deoptimization of exception handlers, the handler address in the stack is converted to a pair of code object and an index into a separate table of code offsets. The index part is invariant under deoptimization. The index is packed into the handler state field so that handler size does not change. R=vegorov@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+509 lines, -367 lines) Patch
M src/arm/code-stubs-arm.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 3 chunks +14 lines, -11 lines 0 comments Download
M src/arm/frames-arm.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +7 lines, -3 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 4 chunks +74 lines, -64 lines 0 comments Download
M src/ast.h View 7 chunks +18 lines, -6 lines 0 comments Download
M src/code-stubs.h View 6 chunks +11 lines, -5 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +9 lines, -1 line 0 comments Download
M src/frames.h View 2 chunks +8 lines, -3 lines 0 comments Download
M src/frames-inl.h View 3 chunks +9 lines, -9 lines 0 comments Download
M src/full-codegen.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 5 chunks +46 lines, -54 lines 0 comments Download
M src/heap.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 4 chunks +18 lines, -16 lines 0 comments Download
M src/ia32/frames-ia32.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 2 chunks +8 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 3 chunks +76 lines, -52 lines 0 comments Download
M src/objects.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-visiting-inl.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/parser.h View 3 chunks +5 lines, -7 lines 0 comments Download
M src/parser.cc View 11 chunks +43 lines, -24 lines 0 comments Download
M src/v8globals.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8memory.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +17 lines, -14 lines 0 comments Download
M src/x64/frames-x64.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 2 chunks +8 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 3 chunks +81 lines, -59 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
The diff is this, in objects-visiting-inl.h (and there is an analogous comment in the templated ...
9 years, 1 month ago (2011-11-11 13:44:52 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 1 month ago (2011-11-11 13:46:09 UTC) #2
LGTM.

sorry for missing it the first time.

Powered by Google App Engine
This is Rietveld 408576698