Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 8538009: Cleaning up and updating mock_chrome.js (Closed)

Created:
9 years, 1 month ago by Vladislav Kaznacheev
Modified:
9 years, 1 month ago
Reviewers:
SeRya
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

Cleaning up and updating mock_chrome.js BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109626

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M chrome/browser/resources/file_manager/js/metadata_provider.js View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 4 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vladislav Kaznacheev
Please review. The deleted methods are duplicates.
9 years, 1 month ago (2011-11-11 12:43:39 UTC) #1
SeRya
lgtm
9 years, 1 month ago (2011-11-11 13:14:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8538009/1
9 years, 1 month ago (2011-11-11 13:26:31 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-11 14:18:40 UTC) #4
Change committed as 109626

Powered by Google App Engine
This is Rietveld 408576698