Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8538008: Linux: Move base/mime_util* to base/nix. It's not used on any other platform. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, creis+watch_chromium.org, jam, brettw-cc_chromium.org, Timur Iskhodzhanov, Avi (use Gerrit), dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Linux: Move base/mime_util* to base/nix. It's not used on any other platform. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -747 lines) Patch
M base/base.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
D base/mime_util.h View 1 chunk +0 lines, -42 lines 0 comments Download
D base/mime_util_xdg.cc View 1 chunk +0 lines, -675 lines 0 comments Download
A + base/nix/mime_util_xdg.h View 3 chunks +7 lines, -5 lines 0 comments Download
A + base/nix/mime_util_xdg.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/icon_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/icon_loader_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/icon_manager_linux.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/dialogs_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/dialogs_kde.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/web_drag_source_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/platform_mime_util_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
I need both of you to cover the needed OWNERS reviews.
9 years, 1 month ago (2011-11-11 11:11:07 UTC) #1
Alexander Potapenko
On 2011/11/11 11:11:07, Lei Zhang wrote: > I need both of you to cover the ...
9 years, 1 month ago (2011-11-11 11:26:04 UTC) #2
Lei Zhang
On 2011/11/11 11:26:04, Alexander Potapenko wrote: > Are there any heapchecker suppressions related to this ...
9 years, 1 month ago (2011-11-11 18:03:35 UTC) #3
willchan no longer on Chromium
9 years, 1 month ago (2011-11-11 19:39:36 UTC) #4 
LGTM

I think Brett's on leave.

Powered by Google App Engine
This is Rietveld 408576698