Cleanup: Remove unneeded forward declarations from chrome/browser/chromeos.

Cleanup: Remove unneeded forward declarations from chrome/browser/chromeos.

BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110052

[Lei Zhang, 2011-11-11 11:14:52]

cmasone: login/
satorux: rest of the CL

[Chris Masone, 2011-11-11 16:20:22]

I actually didn't write most of those files :-/

perhaps nikita would be a better reviewer?

On Fri, Nov 11, 2011 at 3:14 AM, <thestig@chromium.org> wrote:

> Reviewers: satorux1, Chris Masone,
>
> Message:
> cmasone: login/
> satorux: rest of the CL
>
> Description:
> Cleanup: Remove unneeded forward declarations from chrome/browser/chromeos.
>
> BUG=none
> TEST=none
>
> Please review this at
http://codereview.chromium.**org/8538002/<http://codereview.chromium.org/8538...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>  M     chrome/browser/chromeos/audio_**handler.h
>  M     chrome/browser/chromeos/cros/**power_library.h
>  M     chrome/browser/chromeos/**customization_document.h
>  M     chrome/browser/chromeos/dbus/**cros_dbus_service.h
>  M     chrome/browser/chromeos/dbus/**dbus_thread_manager.h
>  M     chrome/browser/chromeos/dbus/**power_manager_client.h
>  M     chrome/browser/chromeos/dbus/**power_manager_client.cc
>  M     chrome/browser/chromeos/dbus/**sensors_client.h
>  M     chrome/browser/chromeos/frame/**browser_view.h
>  M     chrome/browser/chromeos/frame/**bubble_window_views.h
>  M     chrome/browser/chromeos/frame/**panel_controller.h
>  M     chrome/browser/chromeos/login/**background_view.h
>  M     chrome/browser/chromeos/login/**base_login_display_host.h
>  M     chrome/browser/chromeos/login/**language_switch_menu.h
>  M     chrome/browser/chromeos/login/**online_attempt.h
>  M     chrome/browser/chromeos/login/**oobe_display.h
>  M     chrome/browser/chromeos/login/**owner_manager.h
>  M     chrome/browser/chromeos/login/**registration_screen.h
>  M     chrome/browser/chromeos/login/**screen_lock_view.h
>  M     chrome/browser/chromeos/login/**screen_locker.h
>  M     chrome/browser/chromeos/login/**screen_locker_tester.h
>  M     chrome/browser/chromeos/login/**update_screen_actor.h
>  M     chrome/browser/chromeos/login/**user_view.h
>  M     chrome/browser/chromeos/login/**web_page_screen.h
>  M     chrome/browser/chromeos/login/**web_page_view.h
>  M     chrome/browser/chromeos/login/**webui_login_display.h
>  M     chrome/browser/chromeos/login/**webui_login_view.h
>  M     chrome/browser/chromeos/login/**webui_screen_locker.h
>  M     chrome/browser/chromeos/login/**wizard_controller.h
>  M     chrome/browser/chromeos/**mobile_config.h
>  M     chrome/browser/chromeos/**notifications/balloon_view.h
>  M     chrome/browser/chromeos/**options/wifi_config_view.h
>  M     chrome/browser/chromeos/**status/network_menu.h
>  M     chrome/browser/chromeos/**status/network_menu_button.h
>  M     chrome/browser/chromeos/**status/power_menu_button.h
>  M     chrome/browser/chromeos/user_**cros_settings_provider.h
>  M     chrome/browser/chromeos/**version_loader.h
>  M     chrome/browser/chromeos/web_**socket_proxy.h
>  M     chrome/browser/chromeos/wm_**message_listener.h
>
>
>

[satorux1, 2011-11-11 17:02:33]

LGTM except for one thing.

BTW, how did you create this patch? Did you use a tool like iwyu.py? Would be
nice if you could write something about it in the patch description.

http://codereview.chromium.org/8538002/diff/1/chrome/browser/chromeos/cros/po...
File chrome/browser/chromeos/cros/power_library.h (right):

http://codereview.chromium.org/8538002/diff/1/chrome/browser/chromeos/cros/po...
chrome/browser/chromeos/cros/power_library.h:1: 
Why is this removed? Please get the line back. :)

[satorux1, 2011-11-11 17:05:27]

Chris, this patch is just to clean up #include's and forward declarations. Lei
needs lgtm from someone in login/OWNERS to check this in.

[Chris Masone, 2011-11-11 17:16:09]

I'm aware of what it's for, but I frankly shouldn't be in the OWNERS file
anymore anyway.  I haven't touched that code in 6 months.

Please find an appropriate reviewer.

On Fri, Nov 11, 2011 at 9:05 AM, <satorux@chromium.org> wrote:

> Chris, this patch is just to clean up #include's and forward declarations.
> Lei
> needs lgtm from someone in login/OWNERS to check this in.
>
>
http://codereview.chromium.**org/8538002/<http://codereview.chromium.org/8538...
>

[Lei Zhang, 2011-11-11 19:54:10]

On 2011/11/11 17:02:33, satorux1 wrote:
> LGTM except for one thing.
> 
> BTW, how did you create this patch? Did you use a tool like iwyu.py? Would be
> nice if you could write something about it in the patch description.

It's a quick and dirty 10 line bash script, using find and grep.

[Lei Zhang, 2011-11-11 19:54:49]

davemoore: looks like I still need a chrome/browser/chromeos/status OWNERS
review.

http://codereview.chromium.org/8538002/diff/1/chrome/browser/chromeos/cros/po...
File chrome/browser/chromeos/cros/power_library.h (right):

http://codereview.chromium.org/8538002/diff/1/chrome/browser/chromeos/cros/po...
chrome/browser/chromeos/cros/power_library.h:1: 
On 2011/11/11 17:02:33, satorux1 wrote:
> Why is this removed? Please get the line back. :)

whoops, fixed.

[Nikita (slow), 2011-11-14 11:24:32]

chromeos/login lgtm