Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8538001: Cleanup: Remove unneeded forward declarations in printing, sandbox, and skia. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: Remove unneeded forward declarations in printing, sandbox, and skia. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109961

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -33 lines) Patch
M printing/emf_win.h View 1 2 chunks +1 line, -1 line 0 comments Download
M printing/metafile.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M printing/pdf_metafile_cg_mac.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M printing/printed_document.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M printing/printed_pages_source.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M printing/printing_context_no_system_dialog.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M sandbox/sandbox_poc/main_ui_window.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M sandbox/src/sandbox.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M sandbox/src/sandbox_policy_base.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M sandbox/src/target_process.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M skia/ext/platform_device.h View 1 3 chunks +4 lines, -6 lines 0 comments Download
M skia/ext/vector_platform_device_skia.h View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
9 years, 1 month ago (2011-11-11 03:03:54 UTC) #1
vandebo (ex-Chrome)
LGTM You may need an owner for sandbox/ changed though.
9 years, 1 month ago (2011-11-11 17:49:10 UTC) #2
Lei Zhang
On 2011/11/11 17:49:10, vandebo wrote: > LGTM > > You may need an owner for ...
9 years, 1 month ago (2011-11-11 22:36:23 UTC) #3
Lei Zhang
cpu: Take a look at sandbox/ ?
9 years, 1 month ago (2011-11-11 22:36:37 UTC) #4
rvargas (doing something else)
On 2011/11/11 22:36:23, Lei Zhang wrote: > On 2011/11/11 17:49:10, vandebo wrote: > > LGTM ...
9 years, 1 month ago (2011-11-12 02:25:20 UTC) #5
cpu_(ooo_6.6-7.5)
sorry for the delay, I am ooo. lgtm. ps. care to update the copyright years?
9 years, 1 month ago (2011-11-13 00:26:29 UTC) #6
Lei Zhang
On 2011/11/13 00:26:29, cpu wrote: > ps. care to update the copyright years? Done.
9 years, 1 month ago (2011-11-14 21:08:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8538001/9001
9 years, 1 month ago (2011-11-14 21:08:49 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-14 22:27:19 UTC) #9 
Change committed as 109961

Powered by Google App Engine
This is Rietveld 408576698