Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 8537032: Prevent unused-variable warnings in the CrOS build with gcc 4.6. (Closed)

Created:
9 years, 1 month ago by Ami GONE FROM CHROMIUM
Modified:
9 years, 1 month ago
Reviewers:
DaveMoore, jam
CC:
chromium-reviews, jam, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, darin-cc_chromium.org, zel, Nikita (slow), flackr
Visibility:
Public.

Description

Prevent unused-variable warnings in the CrOS build with gcc 4.6. BUG=none TEST=trybots, local cros/arm build of chrome succeeds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110407

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M chrome/browser/chromeos/cros/mount_library.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/image_decoder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker_views.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ami GONE FROM CHROMIUM
jam: please review the CL, and specifically looking to you for ipc/OWNERS-review. (rest of CL ...
9 years, 1 month ago (2011-11-12 03:48:20 UTC) #1
Ami GONE FROM CHROMIUM
Oops, my ipc/ change was crackfull. A better fix is to fix the mismatched IPC_BEGIN_MESSAGE_MAP/IPC_END_MESSAGE_MAP_EX ...
9 years, 1 month ago (2011-11-12 04:08:41 UTC) #2
jam
lgtm
9 years, 1 month ago (2011-11-14 18:42:56 UTC) #3
Ami GONE FROM CHROMIUM
zelidrag: oops, missed that c/b/c/cros has an OWNERS, so I need your review, not just ...
9 years, 1 month ago (2011-11-14 18:46:17 UTC) #4
Ami GONE FROM CHROMIUM
davemoore: please OWNERS-review.
9 years, 1 month ago (2011-11-16 17:06:58 UTC) #5
DaveMoore
lgtm
9 years, 1 month ago (2011-11-16 23:36:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/8537032/3001
9 years, 1 month ago (2011-11-16 23:39:03 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-17 00:52:32 UTC) #8
Change committed as 110407

Powered by Google App Engine
This is Rietveld 408576698