Issue 8537031: Fix size regression due to missing strip.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8537031: Fix size regression due to missing strip. (Closed)

Created:
9 years, 1 month ago by noelallen1

Modified:
9 years, 1 month ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix size regression due to missing strip. Add a strip script based on the old build_nacl_irt.py (just keep strip piece) Rename nacl_irt target to nacl_irt_unstripped and add a new target called nacl_irt which strips the previous target. NOTE: Resubmit of http://codereview.chromium.org/8539039/ which broke 32 bit due to a missing comma in the gyp file. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109771

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -3 lines)			Patch
	A	chrome/strip_nacl_irt.py	View		1 chunk	+77 lines, -0 lines	0 comments	Download
	M	ppapi/native_client/native_client.gyp	View	1 2	2 chunks	+64 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages