Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 8537026: Pepper: Implement PPB_NetAddress_Private Describe() for IPv4 on Windows. (Closed)

Created:
9 years, 1 month ago by viettrungluu
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Implement PPB_NetAddress_Private Describe() for IPv4 on Windows. BUG=103955, 103969 TEST=ui_tests: {OutOfProcessPPAPITests,PPAPITests}.NetAddressPrivate TBR=dmichael@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109783

Patch Set 1 #

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M ppapi/shared_impl/private/net_address_private_impl.cc View 1 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
viettrungluu
NetAddressToString doesn't work in the sandbox on Windows (needs Winsock to be init'ed). I'll do ...
9 years, 1 month ago (2011-11-11 23:41:33 UTC) #1
yzshen1
lgtm
9 years, 1 month ago (2011-11-12 00:08:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/8537026/2001
9 years, 1 month ago (2011-11-12 05:06:42 UTC) #3
commit-bot: I haz the power
Presubmit check for 8537026-2001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-12 05:06:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/8537026/2001
9 years, 1 month ago (2011-11-12 05:14:57 UTC) #5
viettrungluu
OWNERS TBR -> dmichael
9 years, 1 month ago (2011-11-12 05:15:16 UTC) #6
commit-bot: I haz the power
Change committed as 109783
9 years, 1 month ago (2011-11-12 07:38:33 UTC) #7
dmichael (off chromium)
9 years, 1 month ago (2011-11-14 16:11:46 UTC) #8
lgtm

Powered by Google App Engine
This is Rietveld 408576698