Implement automatic loading of dart:core_native_fields library

vm/object.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "vm/assembler.h"
 #include "vm/assert.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
@@ skipping 404 matching lines @@
   // Last element contains the count of used slots.
   array.SetAt(kInitialSymbolTableSize, Smi::Handle(Smi::New(0)));
   object_store->set_symbol_table(array);
 
   // Basic infrastructure has been setup, initialize the class dictionary.
   Library::InitCoreLibrary(isolate);
   Library& core_lib = Library::Handle(isolate->object_store()->core_library());
   ASSERT(!core_lib.IsNull());
   Library& core_impl_lib = Library::Handle(Library::CoreImplLibrary());
   ASSERT(!core_impl_lib.IsNull());
+  Library::InitNativeFieldsLibrary(isolate);
+  ASSERT(isolate->object_store()->native_fields_library() != Library::null());
 
   // Allocate pre-initialized values.
   Bool& bool_value = Bool::Handle();
   bool_value = Bool::New(true);
   object_store->set_true_value(bool_value);
   bool_value = Bool::New(false);
   object_store->set_false_value(bool_value);
 
   object_store->set_pending_classes(Array::Handle(Array::Empty()));
 
@@ skipping 3648 matching lines @@
   const Library& core_impl_lib =
       Library::Handle(Library::NewLibraryHelper(core_impl_lib_url, false));
   isolate->object_store()->set_core_impl_library(core_impl_lib);
   core_impl_lib.Register();
   core_lib.AddImport(core_impl_lib);
   core_impl_lib.AddImport(core_lib);
   isolate->object_store()->set_root_library(Library::Handle());
 }
 
 
+void Library::InitNativeFieldsLibrary(Isolate* isolate) {
+  static const int kNumNativeFieldClasses = 4;
+  ASSERT(kNumNativeFieldClasses > 0 && kNumNativeFieldClasses < 10);
+  const String& native_flds_lib_url = String::Handle(
+      String::NewSymbol("dart:core_native_fields"));

[Anton Muhin, 2011/11/13 16:19:32]

somehow reuse kCoreNativeFieldsLibURL?

[siva, 2011/11/15 02:16:52]

Agree, would be nice, we need to expose thse through the API for that to work.
Probably another CL.

On 2011/11/13 16:19:32, antonmuhin wrote:

+  Library& native_flds_lib = Library::Handle(
+      Library::NewLibraryHelper(native_flds_lib_url, false));
+  native_flds_lib.Register();
+  isolate->object_store()->set_native_fields_library(native_flds_lib);
+  const String& name = String::Handle(String::New("NativeFieldWrapperClass"));
+  String& index_str = String::Handle();
+  String& cls_name = String::Handle();
+  static const int kBufferSize = 2;
+  char chars[kBufferSize];
+  for (int fld_cnt = 1; fld_cnt <= kNumNativeFieldClasses; fld_cnt++) {
+    OS::SNPrint(chars, kBufferSize, "%d", fld_cnt);

[Anton Muhin, 2011/11/13 16:19:32]

up to you, but for me something like below would be more natural:

const char* const nativeClassPrefix = "NativeFieldWrapperClass";
const int class_name_len = strlen(nativeClassPrefix) + 1 + 1;
char class_name[class_name_len] = {0};

for (...) {
  OS::SNPrint(class_name, strlen(class_name) /* or class_name_len */, "%s%d",
....);
}

[siva, 2011/11/15 02:16:52]

Done.

+    index_str = String::New(chars);
+    cls_name = String::Concat(name, index_str);
+    cls_name = String::NewSymbol(cls_name);
+    Class::NewNativeWrapper(&native_flds_lib, cls_name, fld_cnt);
+  }
+}
+
+
 RawLibrary* Library::LookupLibrary(const String &url) {
   Library& lib = Library::Handle();
   String& lib_url = String::Handle();
   lib = Isolate::Current()->object_store()->registered_libraries();
   while (!lib.IsNull()) {
     lib_url = lib.url();
     if (lib_url.Equals(url)) {
       return lib.raw();
     }
     lib = lib.next_registered();
@@ skipping 50 matching lines @@
 RawLibrary* Library::CoreLibrary() {
   return Isolate::Current()->object_store()->core_library();
 }
 
 
 RawLibrary* Library::CoreImplLibrary() {
   return Isolate::Current()->object_store()->core_impl_library();
 }
 
 
+RawLibrary* Library::NativeFieldsLibrary() {
+  return Isolate::Current()->object_store()->native_fields_library();
+}
+
+
 const char* Library::ToCString() const {
   const char* kFormat = "Library:'%s'";
   const String& name = String::Handle(url());
   intptr_t len = OS::SNPrint(NULL, 0, kFormat, name.ToCString()) + 1;
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len));
   OS::SNPrint(chars, len, kFormat, name.ToCString());
   return chars;
 }
 
@@ skipping 2791 matching lines @@
   const String& str = String::Handle(pattern());
   const char* format = "JSRegExp: pattern=%s flags=%s";
   intptr_t len = OS::SNPrint(NULL, 0, format, str.ToCString(), Flags());
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len + 1));
   OS::SNPrint(chars, (len + 1), format, str.ToCString(), Flags());
   return chars;
 }
 
 }  // namespace dart