Implement automatic loading of dart:core_native_fields library

vm/class_finalizer.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/class_finalizer.h"
 
 #include "vm/flags.h"
 #include "vm/heap.h"
 #include "vm/isolate.h"
 #include "vm/longjump.h"
@@ skipping 894 matching lines @@
   }
   // Mark as finalized before resolving type parameter upper bounds and member
   // types in order to break cycles.
   cls.Finalize();
   ResolveAndFinalizeUpperBounds(cls);
   ResolveAndFinalizeMemberTypes(cls);
   // Run additional checks after all types are finalized.
   if (cls.is_const()) {
     CheckForLegalConstClass(cls);
   }
+  // Check to ensure we don't have classes with native fields in libraries
+  // which do not have a native resolver.
+  if (cls.num_native_fields() != 0) {
+    const Library& lib = Library::Handle(cls.library());
+    if (lib.native_entry_resolver() == NULL) {
+      const String& name = String::Handle(cls.Name());
+      ReportError("class '%s' is invalid, it is extending an invalid class.\n",

[Anton Muhin, 2011/11/15 12:22:23]

very nice check, but message looks slightly misleading.  Maybe something along
'class %s with native fields, but no native resolver for lib %s'?

[siva, 2011/11/15 19:42:49]

Done.

+                  name.ToCString());
+    }
+  }
 }
 
 
 bool ClassFinalizer::IsSuperCycleFree(const Class& cls) {
   Class& test1 = Class::Handle(cls.raw());
   Class& test2 = Class::Handle(cls.SuperClass());
   // A finalized class has been checked for cycles.
   // Using the hare and tortoise algorithm for locating cycles.
   while (!test1.is_finalized() &&
          !test2.IsNull() && !test2.is_finalized()) {
@@ skipping 229 matching lines @@
   ASSERT(msg_buffer != NULL);
   va_list args;
   va_start(args, format);
   OS::VSNPrint(msg_buffer, kBufferLength, format, args);
   va_end(args);
   isolate->long_jump_base()->Jump(1, msg_buffer);
   UNREACHABLE();
 }
 
 }  // namespace dart