GTK: Shave ~15ms off each tab change.

GTK: Shave ~15ms off each tab change.

Reparenting the bookmark bar on each tab change whether it needs it or not
costs about 15ms. This usually is enough savings to get one more frame out of
the new tab animation early on.

Also, it's the Browser object's responsibility to update our toolbar; remove a duplicate call that already happened before the BrowserWindowGtk::ActiveTabChanged() Observer method was called.

BUG=83106
TEST=Everything works about the bookmarks bar when changing tabs

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109928

[Evan Stade, 2011-11-12 00:06:26]

http://codereview.chromium.org/8537022/diff/1/chrome/browser/ui/gtk/browser_w...
File chrome/browser/ui/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/8537022/diff/1/chrome/browser/ui/gtk/browser_w...
chrome/browser/ui/gtk/browser_window_gtk.cc:1257: // It's the Browser object's
responsibility to update our toolbar; this
I don't think this comment is strictly necessary although it might be good to
have the CL description. If there is code that you think is really likely to be
added, but doesn't belong somewhere, I'd say leave the code and comment it out
with a note as to why it's commented.

[Evan Stade, 2011-11-12 00:06:32]

lgtm

[commit-bot: I haz the power, 2011-11-14 17:57:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/8537022/5001

[commit-bot: I haz the power, 2011-11-14 19:12:50]

Change committed as 109928