Send correct termination reason when session is terminated by the host.

remoting/protocol/jingle_messages.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_JINGLE_MESSAGES_H_
 #define REMOTING_PROTOCOL_JINGLE_MESSAGES_H_
 
 #include <list>
 #include <string>
 
@@ skipping 21 matching lines @@
     SESSION_TERMINATE,
     TRANSPORT_INFO,
   };
 
   enum Reason {
     // Currently only termination reasons that can be sent by the host
     // are understood. All others are converted to UNKNOWN_REASON.
     UNKNOWN_REASON,
     SUCCESS,
     DECLINE,
+    GENERAL_ERROR,

[Wez, 2011/11/11 23:10:09]

How does a "general error" differ from an "unknown reason"?

[Sergey Ulanov, 2011/11/12 00:02:52]

It's basically the same. Jingle defines it as "The action is related to a
non-specific application error."

     INCOMPATIBLE_PARAMETERS,

[Wez, 2011/11/11 23:10:09]

These are all macro-style and don't have very consistent names. :(

[Sergey Ulanov, 2011/11/12 00:02:52]

That's required by style guide.
they correspond to names defined by jingle spec.

[Wez, 2011/11/15 02:30:05]

Style guide allows both forms and prefers non-macro-style unless it's for
consistency with existing code, though.

[Sergey Ulanov, 2011/11/15 02:37:21]

Chromium style guide (http://www.chromium.org/developers/coding-style) says:
  Though the style guide says to use kConstantNaming for enums now, we still use
MACRO_STYLE naming for enums for consistency with existing code.

It is worded ambiguously, but it think the right way to interpret is to always
use MACRO_STYLE for enums.

   };
 
   JingleMessage();
   JingleMessage(const std::string& to_value,
                 ActionType action_value,
                 const std::string& sid_value);
   ~JingleMessage();
 
   // Caller keeps ownership of |stanza|.
   static bool IsJingleMessage(const buzz::XmlElement* stanza);
@@ skipping 43 matching lines @@
 
   ReplyType type;
   ErrorType error_type;
   std::string text;
 };
 
 }  // protocol
 }  // remoting
 
 #endif  // REMOTING_PROTOCOL_JINGLE_MESSAGES_H_