Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7295)

Unified Diff: chrome/browser/sync/protocol/app_specifics.proto

Issue 8537017: Add oauth client id to AppSpecifics. We will use that when a user revokes notification permission. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/protocol/app_specifics.proto
===================================================================
--- chrome/browser/sync/protocol/app_specifics.proto (revision 108838)
+++ chrome/browser/sync/protocol/app_specifics.proto (working copy)
@@ -19,6 +19,7 @@
// Settings related to push notifications for apps.
message AppNotificationSettings {
+ // DEPRECATED: Use oauth_client_id below.
// Whether or not the user has setup notifications at least once.
// The value for this field will start out false and will be set
// to true when the user accepts receiving notifications for the
@@ -27,6 +28,15 @@
// Whether or not the user has disabled notifications.
optional bool disabled = 2;
+
+ // OAuth2 client id to which the user granted the notification permission.
+ // This field will start out empty.
+ // It will be set when the user accepts receiving notifications.
+ // This field is used when the user revokes the notifications permission.
+ // Note that it is never cleared after it was set once. Hence, the presence
+ // of this field can be used to determine if the user has setup notifications
+ // at least once for the given app.
+ optional string oauth_client_id = 3;
}
// Properties of app sync objects.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698