Find out the Webkit layout_tests names by reading their stdout

tools/valgrind/valgrind_test.py

 #!/usr/bin/python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # valgrind_test.py
 
 """Runs an exe through Valgrind and puts the intermediate files in a
 directory.
 """
@@ skipping 372 matching lines @@
                                "in the tool-specific subclass"
 
   def CreateBrowserWrapper(self, proc):
     """The program being run invokes Python or something else that can't stand
     to be valgrinded, and also invokes the Chrome browser. In this case, use a
     magic wrapper to only valgrind the Chrome browser. Build the wrapper here.
     Returns the path to the wrapper. It's up to the caller to use the wrapper
     appropriately.
     """
     command = " ".join(proc)
+    # Add the PID of the browser wrapper to the logfile names so we can
+    # separate log files for different UI tests at the analyze stage.
     command = command.replace("%p", "$$.%p")
 
     (fd, indirect_fname) = tempfile.mkstemp(dir=self.log_dir,
                                             prefix="browser_wrapper.",
                                             text=True)
     f = os.fdopen(fd, "w")
-    f.write("#!/bin/bash\n")
-    f.write('echo "Started Valgrind wrapper for this test, PID=$$"\n\n')
-    f.write('for arg in $@\ndo\n')
-    f.write('  if [[ "$arg" =~ --test-name=(.*) ]]\n then\n')
-    f.write('    TESTCASE=${BASH_REMATCH[1]}\n')
-    f.write('    echo $TESTCASE >`dirname $0`/testcase.$$.name\n')
-    f.write('  fi\ndone\n')
-    # Add the PID of the browser wrapper to the logfile names so we can
-    # separate log files for different UI tests at the analyze stage.
-    f.write(command)
-    f.write(' "$@"\n')
+    f.write('#!/bin/bash\n'
+            'echo "Started Valgrind wrapper for this test, PID=$$"\n')
+
+    # Try to get the test case name by looking at the program arguments.
+    # i.e. Chromium ui_tests and friends pass --test-name arg.
+    f.write('DIR=`dirname $0`\n'
+            'FOUND_TESTNAME=0\n'
+            'TESTNAME_FILE=$DIR/testcase.$$.name\n'
+            'for arg in $@; do\n'

[Lei Zhang, 2011/11/12 00:03:37]

FYI, this doesn't handle arguments with spaces, but maybe we don't care since we
are looking for '--test-name=NoSpaces.Here'

[Timur Iskhodzhanov, 2011/11/12 19:42:11]

True; added a TODO just in case

On 2011/11/12 00:03:37, Lei Zhang wrote:

+            '  if [[ "$arg" =~ --test-name=(.*) ]]; then\n'
+            '    echo ${BASH_REMATCH[1]} >$TESTNAME_FILE\n'
+            '    FOUND_TESTNAME=1\n'
+            '  fi\n'
+            'done\n\n')
+
+    f.write('if [ "$FOUND_TESTNAME" == "1" ]; then\n'

[Lei Zhang, 2011/11/12 00:03:37]

nit: == is valid in bash, but can you use = so people used to portable shell
won't get alarmed?

[Timur Iskhodzhanov, 2011/11/12 19:42:11]

Ok, the C++ part of me is too defensive :)

On 2011/11/12 00:03:37, Lei Zhang wrote:

+            '    %s "$@"\n'
+            'else\n' % command)
+    # Webkit layout_tests print out the test URL as the first line of stdout.
+    f.write('    %s "$@" | tee $DIR/test.$$.stdout\n'

[Timur Iskhodzhanov, 2011/11/11 15:22:24]

pardon: accidentally removed the initial patchset.

Pay special attention to this part of the code

+            '    EXITCODE=$PIPESTATUS\n'  # $? holds the tee's exit code
+            '    head -n 1 $DIR/test.$$.stdout | \n'
+            '      sed "s/^.*third_party\/WebKit\/LayoutTests\///" '
+                       '>$TESTNAME_FILE\n'
+            '    exit $EXITCODE\n'
+            'fi\n' % command)
+
     f.close()
     os.chmod(indirect_fname, stat.S_IRUSR|stat.S_IXUSR)
     return indirect_fname
 
   def CreateAnalyzer(self):
     raise NotImplementedError, "This method should be implemented " \
                                "in the tool-specific subclass"
 
   def GetAnalyzeResults(self, check_sanity=False):
     # Glob all the files in the "testing.tmp" directory
@@ skipping 696 matching lines @@
       platform_name = sys.platform + "(Unknown)"
     raise RuntimeError, "Unknown tool (tool=%s, platform=%s)" % (tool_name,
                                                                  platform_name)
 
 def CreateTool(tool):
   return ToolFactory().Create(tool)
 
 if __name__ == '__main__':
   logging.error(sys.argv[0] + " can not be run from command line")
   sys.exit(1)