Enable frong testing components.

tools/testing/dart/test_runner.dart

Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 678fd605a2cd11621ca838cbe3e9c207d2ac1c0a..c4a1a0429d48dd28f33bfccbcb331258810b528f 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -33,12 +33,18 @@ String getBuildDir(Map configuration) {
 
 
 String getExecutableName(Map configuration) {
-  if (configuration['component'] == 'vm') {
-    return 'dart_bin';
-  } else if (configuration['component'] == 'dartc') {
-    return 'dartc';
-  } else {
-    throw "Unknown executable for: ${configuration['component']}";
+  switch (configuration['component']) {
+    case 'vm':
+      return 'dart_bin';
+    case 'dartc':
+      return 'dartc';
+    case 'frog':
+    case 'leg':
+      return 'frog/bin/frog';
+    case 'frogsh':
+      return 'frog/bin/frogsh';
+    default:
+      throw "Unknown executable for: ${configuration['component']}";
   }
 }
 
@@ -55,6 +61,7 @@ String getDartShellFileName(Map configuration) {
 class TestCase {
   String executablePath;
   List<String> arguments;
+  int timeout;
   String commandLine;
   String displayName;
   TestOutput output;
@@ -62,7 +69,7 @@ class TestCase {
   Function completedHandler;
 
   TestCase(this.displayName, this.executablePath, this.arguments,
-           this.completedHandler, this.expectedOutcomes) {
+           this.timeout, this.completedHandler, this.expectedOutcomes) {
     commandLine = executablePath;
     for (var arg in arguments) {
       commandLine += " " + arg;
@@ -95,7 +102,9 @@ class TestOutput {
 
   bool get unexpectedOutput() => !testCase.expectedOutcomes.contains(result);
   
-  bool get hasCrashed() => !timedOut && exitCode != -1 && exitCode != 0;
+  bool get hasCrashed() {
+    return !timedOut && exitCode != -1 && exitCode < 0;

[Bill Hesse, 2011/11/11 13:42:52]

Why the curly braces?

[Mads Ager (google), 2011/11/11 14:02:07]

Thanks. I'll get rid of them. I added that while debugging. :)

+  }
 
   bool get hasTimedOut() => timedOut;
 
@@ -172,15 +181,20 @@ class ProcessQueue {
   final int maxProcesses;
   Queue<TestCase> tests;
   ProgressIndicator progress;
+  var onDone;
 
-  ProcessQueue(this.maxProcesses, this.progress)
-      : tests = new Queue<TestCase>();
+  ProcessQueue(Map configuration, this.onDone)
+      : tests = new Queue<TestCase>(),
+        maxProcesses = configuration['tasks'],
+        progress = new CompactProgressIndicator();
 
   tryRunTest() {
+    if (tests.isEmpty() && numProcesses == 0) {
+      onDone();
+    }

[Bill Hesse, 2011/11/11 13:42:52]

This looks like a race condition - if one test is entered in the queue, and the
process runs and ends before a second test is entered in the queue, then
tryRunTest is called from the test.completedHandler() and this condition is
true.

[Mads Ager (google), 2011/11/11 14:02:07]

That is true. This is all temporary. I will rip it out as soon as stdout is
closed automatically when there are no other pending tasks. I'll add a TODO
comment and leave it as is until I can rip it all out. In practice the listing
happens so quickly that the problem you are describing does not occur.

     if (numProcesses < maxProcesses && !tests.isEmpty()) {
       TestCase test = tests.removeFirst();
       progress.start(test);
-      // TODO(whesse): Refactor into various test output methods.
       Function old_callback = test.completedHandler;
       Function wrapper = (TestCase test_arg) {
         numProcesses--;
@@ -189,9 +203,7 @@ class ProcessQueue {
         old_callback(test_arg);
       };
       test.completedHandler = wrapper;
-        
-      // TODO(whesse): Add timeout information to TestCase, use it here.
-      new RunningProcess(test, 60).start();
+      new RunningProcess(test, test.timeout).start();
       numProcesses++;
     }
   }