Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8537007: Cleanup: Remove unneeded forward declarations from chrome/browser/ui/webui. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
Reviewers:
Evan Stade
CC:
chromium-reviews, nkostylev+watch_chromium.org, Erik does not do reviews, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, estade+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Remove unneeded forward declarations from chrome/browser/ui/webui. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109772

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -68 lines) Patch
M chrome/browser/ui/webui/bookmarks_ui.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.h View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extension_icon_source.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/favicon_source.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/fileicon_source.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/fileicon_source_chromeos.h View 1 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/webui/html_dialog_tab_contents_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/keyboard_ui.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.h View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/ntp/bookmarks_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_login_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/extension_settings_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_ui.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/shared_resources_data_source.h View 1 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/sync_internals_ui.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/task_manager_ui.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/workers_ui.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
9 years, 1 month ago (2011-11-11 10:09:07 UTC) #1
Evan Stade
rubber stamp lgtm thanks
9 years, 1 month ago (2011-11-11 22:38:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8537007/2006
9 years, 1 month ago (2011-11-12 01:58:48 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-12 03:55:01 UTC) #4 
Change committed as 109772

Powered by Google App Engine
This is Rietveld 408576698