Issue 8537005: Revert 109594 - Forward Windows touch messages to the renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8537005: Revert 109594 - Forward Windows touch messages to the renderer (Closed)

Created:
9 years, 1 month ago by Lei Zhang

Modified:
9 years, 1 month ago

Reviewers:
jschuh

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, jam, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 109594 - Forward Windows touch messages to the renderer Review URL: http://codereview.chromium.org/8341125 TBR=jschuh@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109596

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -260 lines)			Patch
M	content/browser/renderer_host/render_widget_host_view_win.h	View	3 chunks	+0 lines, -40 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_win.cc	View	7 chunks	+14 lines, -216 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jschuh

9 years, 1 month ago (2011-11-11 14:15:51 UTC) #3

On 2011/11/11 08:28:54, Lei Zhang wrote:
> XP bots all went red. =(

I forgot to put a Windows version check before calling IsTouchWindow in
OnDestroy. So, XP choked on the delay load. Unfortunately, we have no XP trybot
coverage, so I'll retest it manually before landing again.

Sorry about that and thanks for rolling it out.

Expand Messages | Collapse Messages