Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8537003: Cleanup: Remove unneeded forward declarations in chrome/browser/sync. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
CC:
chromium-reviews, ncarter (slow), akalin, Raghu Simha, cbentzel+watch_chromium.org, darin-cc_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Cleanup: Remove unneeded forward declarations in chrome/browser/sync. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110141

Patch Set 1 : '' #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -106 lines) Patch
M chrome/browser/sync/engine/all_status.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/apply_updates_command.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/sync/engine/build_and_process_conflict_sets_command.h View 1 2 chunks +1 line, -2 lines 0 comments Download
MM chrome/browser/sync/engine/clear_data_command.h View 1 3 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/sync/engine/net/server_connection_manager.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/nigori_util.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/resolve_conflicts_command.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/sync/engine/syncer.h View 1 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/sync/engine/syncer_proto_util.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/engine/syncer_proto_util.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/syncer_proto_util_unittest.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sync/engine/syncer_types.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/verify_updates_command.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/history_model_worker.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/password_change_processor.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/password_model_associator.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.h View 1 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_model_associator.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sync/internal_api/change_record.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/internal_api/read_node.h View 1 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/sync/internal_api/sync_manager.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/sync/internal_api/write_node.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_factory.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/sessions/session_state.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/syncable/syncable.h View 1 4 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/sync/test/engine/mock_connection_manager.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
9 years, 1 month ago (2011-11-11 08:09:17 UTC) #1
Lei Zhang
will take review from any owner
9 years, 1 month ago (2011-11-15 08:12:46 UTC) #2
tim (not reviewing)
LGTM Thanks
9 years, 1 month ago (2011-11-15 16:04:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8537003/8001
9 years, 1 month ago (2011-11-15 18:08:47 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 19:19:25 UTC) #5 
Change committed as 110141

Powered by Google App Engine
This is Rietveld 408576698