Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8537001: chromeos: Power manager client calls shutdown and restart (Closed)

Created:
9 years, 1 month ago by Simon Que
Modified:
9 years, 1 month ago
Reviewers:
stevenjb, satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

chromeos: Power manager client calls shutdown and restart No longer using libcros to call these methods. Part of libcros removal. BUG=chromium-os:16558 TEST=Attempt shutdown and restart from Chrome UI Signed-off-by: Simon Que <sque@chromium.org>; R=satorux@chromium.org,stevenjb@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109778

Patch Set 1 #

Total comments: 8

Patch Set 2 : Rebased, changed to use EmptyResponseCallback #

Total comments: 2

Patch Set 3 : removed DCHECK for power library #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -30 lines) Patch
M chrome/browser/chromeos/cros/mock_power_library.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/cros/power_library.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/cros/power_library.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/dbus/mock_power_manager_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/dbus/power_manager_client.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/dbus/power_manager_client.cc View 1 2 chunks +25 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/shutdown_button.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/update_recommended_message_box.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/about_page_handler.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Simon Que
9 years, 1 month ago (2011-11-11 02:55:35 UTC) #1
satorux1
LGTM with one request. http://codereview.chromium.org/8537001/diff/1/chrome/browser/chromeos/login/shutdown_button.cc File chrome/browser/chromeos/login/shutdown_button.cc (right): http://codereview.chromium.org/8537001/diff/1/chrome/browser/chromeos/login/shutdown_button.cc#newcode117 chrome/browser/chromeos/login/shutdown_button.cc:117: DCHECK(CrosLibrary::Get()->EnsureLoaded()); Please remove this line. ...
9 years, 1 month ago (2011-11-11 05:42:09 UTC) #2
satorux1
http://codereview.chromium.org/8537001/diff/1/chrome/browser/chromeos/dbus/power_manager_client.cc File chrome/browser/chromeos/dbus/power_manager_client.cc (right): http://codereview.chromium.org/8537001/diff/1/chrome/browser/chromeos/dbus/power_manager_client.cc#newcode139 chrome/browser/chromeos/dbus/power_manager_client.cc:139: weak_ptr_factory_.GetWeakPtr())); Please use dbus::ObjectProxy::EmptyResponseCallback(), which I added last night. ...
9 years, 1 month ago (2011-11-11 18:04:59 UTC) #3
Simon Que
PTAL http://codereview.chromium.org/8537001/diff/1/chrome/browser/chromeos/dbus/power_manager_client.cc File chrome/browser/chromeos/dbus/power_manager_client.cc (right): http://codereview.chromium.org/8537001/diff/1/chrome/browser/chromeos/dbus/power_manager_client.cc#newcode139 chrome/browser/chromeos/dbus/power_manager_client.cc:139: weak_ptr_factory_.GetWeakPtr())); On 2011/11/11 18:04:59, satorux1 wrote: > Please ...
9 years, 1 month ago (2011-11-11 18:56:53 UTC) #4
satorux1
LGTM with one request. http://codereview.chromium.org/8537001/diff/6001/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right): http://codereview.chromium.org/8537001/diff/6001/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc#newcode546 chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:546: DCHECK(CrosLibrary::Get()->EnsureLoaded()); Please remove this line.
9 years, 1 month ago (2011-11-11 19:03:31 UTC) #5
Simon Que
PTAL http://codereview.chromium.org/8537001/diff/6001/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right): http://codereview.chromium.org/8537001/diff/6001/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc#newcode546 chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:546: DCHECK(CrosLibrary::Get()->EnsureLoaded()); On 2011/11/11 19:03:31, satorux1 wrote: > Please ...
9 years, 1 month ago (2011-11-11 20:31:04 UTC) #6
satorux1
LGTM
9 years, 1 month ago (2011-11-11 22:24:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sque@chromium.org/8537001/1011
9 years, 1 month ago (2011-11-12 03:24:59 UTC) #8
commit-bot: I haz the power
Try job failure for 8537001-1011 on linux_clang for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=1273 Step "update" is always ...
9 years, 1 month ago (2011-11-12 03:29:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sque@chromium.org/8537001/1011
9 years, 1 month ago (2011-11-12 04:44:34 UTC) #10
commit-bot: I haz the power
Change committed as 109778
9 years, 1 month ago (2011-11-12 07:14:42 UTC) #11
Timur Iskhodzhanov
9 years, 1 month ago (2011-11-12 20:04:34 UTC) #12

Powered by Google App Engine
This is Rietveld 408576698