Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 8536055: base::Bind() conversion for crash handler/uploader. (Closed)

Created:
9 years, 1 month ago by dcheng
Modified:
9 years, 1 month ago
Reviewers:
Lei Zhang, stuartmorgan
CC:
chromium-reviews
Visibility:
Public.

Description

base::Bind() conversion for crash handler/uploader. BUG=none TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111223

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M chrome/browser/crash_handler_host_linux.cc View 7 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/crash_upload_list.cc View 1 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcheng
9 years, 1 month ago (2011-11-21 08:09:56 UTC) #1
stuartmorgan
Upload list changes LGTM with nit; I know absolutely nothing about the Linux crash handler, ...
9 years, 1 month ago (2011-11-21 08:36:16 UTC) #2
dcheng
http://codereview.chromium.org/8536055/diff/1/chrome/browser/crash_upload_list.cc File chrome/browser/crash_upload_list.cc (right): http://codereview.chromium.org/8536055/diff/1/chrome/browser/crash_upload_list.cc#newcode57 chrome/browser/crash_upload_list.cc:57: base::Bind(&CrashUploadList::InformDelegateOfCompletion, this)); On 2011/11/21 08:36:16, stuartmorgan wrote: > If ...
9 years, 1 month ago (2011-11-21 17:15:50 UTC) #3
Lei Zhang
LGTM
9 years, 1 month ago (2011-11-22 19:53:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8536055/4001
9 years, 1 month ago (2011-11-22 19:59:56 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 21:44:24 UTC) #6
Change committed as 111223

Powered by Google App Engine
This is Rietveld 408576698