Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: chrome/browser/metrics/metrics_reporting_scheduler.cc

Issue 8536054: Migrate several instances of NewRunnableMethod to base::Bind in browser/metrics (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_reporting_scheduler.h ('k') | chrome/browser/metrics/metrics_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_reporting_scheduler.cc
diff --git a/chrome/browser/metrics/metrics_reporting_scheduler.cc b/chrome/browser/metrics/metrics_reporting_scheduler.cc
index a895584649f543f4f359824964f32a49a45ae56b..3cd53e28153d55c27b8e6e4775d8a11af396894d 100644
--- a/chrome/browser/metrics/metrics_reporting_scheduler.cc
+++ b/chrome/browser/metrics/metrics_reporting_scheduler.cc
@@ -33,7 +33,7 @@ static const int kMaxBackoffMultiplier = 10;
MetricsReportingScheduler::MetricsReportingScheduler(
const base::Closure& upload_callback)
: upload_callback_(upload_callback),
- ALLOW_THIS_IN_INITIALIZER_LIST(upload_timer_factory_(this)),
+ ALLOW_THIS_IN_INITIALIZER_LIST(weak_ptr_factory_(this)),
upload_interval_(TimeDelta::FromSeconds(kInitialUploadIntervalSeconds)),
running_(false),
timer_pending_(false),
@@ -92,8 +92,8 @@ void MetricsReportingScheduler::ScheduleNextCallback() {
MessageLoop::current()->PostDelayedTask(
FROM_HERE,
- upload_timer_factory_.NewRunnableMethod(
- &MetricsReportingScheduler::TriggerUpload),
+ base::Bind(&MetricsReportingScheduler::TriggerUpload,
+ weak_ptr_factory_.GetWeakPtr()),
upload_interval_.InMilliseconds());
}
« no previous file with comments | « chrome/browser/metrics/metrics_reporting_scheduler.h ('k') | chrome/browser/metrics/metrics_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698