Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 8536052: Annotator based "compile and run tests" script for android bot. (Closed)

Created:
9 years, 1 month ago by John Grabowski
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Annotator based "compile and run tests" script for android bot. BUG= TEST=

Patch Set 1 #

Total comments: 2

Patch Set 2 : update conditional syntax to double-bracket #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
A build/android/buildbot.sh View 1 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
John Grabowski
Jeff: please review. Brad: please help make sure I'm using Bradscript as you might expect. ...
9 years, 1 month ago (2011-11-19 02:59:54 UTC) #1
bradn
LGTM http://codereview.chromium.org/8536052/diff/1/build/android/buildbot.sh File build/android/buildbot.sh (right): http://codereview.chromium.org/8536052/diff/1/build/android/buildbot.sh#newcode26 build/android/buildbot.sh:26: if [ \( ! -d "${ANDROID_SDK_ROOT}" \) -o ...
9 years, 1 month ago (2011-11-19 16:40:09 UTC) #2
John Grabowski
Thx http://codereview.chromium.org/8536052/diff/1/build/android/buildbot.sh File build/android/buildbot.sh (right): http://codereview.chromium.org/8536052/diff/1/build/android/buildbot.sh#newcode26 build/android/buildbot.sh:26: if [ \( ! -d "${ANDROID_SDK_ROOT}" \) -o ...
9 years, 1 month ago (2011-11-21 19:23:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrg@chromium.org/8536052/4001
9 years, 1 month ago (2011-11-21 19:45:28 UTC) #4
commit-bot: I haz the power
Can't apply patch for file build/android/buildbot.sh. While running patch -p1 --forward --force; The next patch ...
9 years, 1 month ago (2011-11-21 21:24:23 UTC) #5
John Grabowski
9 years, 1 month ago (2011-11-21 21:27:01 UTC) #6
On 2011/11/21 21:24:23, I haz the power (commit-bot) wrote:
> Can't apply patch for file build/android/buildbot.sh.
> While running patch -p1 --forward --force;
> The next patch would create the file build/android/buildbot.sh,
> which already exists!  Skipping patch.
> 1 out of 1 hunk ignored

Committed as http://src.chromium.org/viewvc/chrome?view=rev&revision=110983

Powered by Google App Engine
This is Rietveld 408576698