Add xvfb option for running android tests on a bot.

Add xvfb option for running android tests on a bot.


BUG=
TEST=

[John Grabowski, 2011-11-19 02:58:34]

Michael: please review for test-ness.
Jeff: please review for bot-ness.

[bradn, 2011-11-19 16:32:20]

lgtm

http://codereview.chromium.org/8536051/diff/1/build/android/run_tests.py
File build/android/run_tests.py (right):

http://codereview.chromium.org/8536051/diff/1/build/android/run_tests.py#newc...
build/android/run_tests.py:99: time.sleep(0.25)
how about exponential back off?
time.sleep(0.25 * math.pow(2, test))

[bradn, 2011-11-19 16:32:31]

Drive by..

[michaelbai, 2011-11-21 17:16:04]

http://codereview.chromium.org/8536051/diff/1/build/android/run_tests.py
File build/android/run_tests.py (right):

http://codereview.chromium.org/8536051/diff/1/build/android/run_tests.py#newc...
build/android/run_tests.py:214: xvfb.Stop()
Do you need?

'if options.use_xvfb: '

[John Grabowski, 2011-11-21 19:26:08]

http://codereview.chromium.org/8536051/diff/1/build/android/run_tests.py
File build/android/run_tests.py (right):

http://codereview.chromium.org/8536051/diff/1/build/android/run_tests.py#newc...
build/android/run_tests.py:214: xvfb.Stop()
On 2011/11/21 17:16:04, michaelbai wrote:
> Do you need?
> 
> 'if options.use_xvfb: '

Yes; added

[michaelbai, 2011-11-21 19:30:23]

lgtm

[commit-bot: I haz the power, 2011-11-21 19:45:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jrg@chromium.org/8536051/4002

[commit-bot: I haz the power, 2011-11-21 19:45:21]

Can't apply patch for file build/android/run_tests.py.
While running patch -p1 --forward --force;
patching file build/android/run_tests.py
Hunk #1 FAILED at 50.
Hunk #2 succeeded at 111 with fuzz 2 (offset 48 lines).
Hunk #3 succeeded at 239 with fuzz 2 (offset 52 lines).
Hunk #4 FAILED at 210.
Hunk #5 FAILED at 246.
3 out of 5 hunks FAILED -- saving rejects to file build/android/run_tests.py.rej

[John Grabowski, 2011-11-21 19:46:55]

On 2011/11/21 19:45:21, I haz the power (commit-bot) wrote:
> Can't apply patch for file build/android/run_tests.py.
> While running patch -p1 --forward --force;
> patching file build/android/run_tests.py
> Hunk #1 FAILED at 50.
> Hunk #2 succeeded at 111 with fuzz 2 (offset 48 lines).
> Hunk #3 succeeded at 239 with fuzz 2 (offset 52 lines).
> Hunk #4 FAILED at 210.
> Hunk #5 FAILED at 246.
> 3 out of 5 hunks FAILED -- saving rejects to file
build/android/run_tests.py.rej

Sigh... I ctrl-c'd a dcommit which landed but didn't update rietveld.

[John Grabowski, 2011-11-21 19:47:37]

On 2011/11/21 19:46:55, John Grabowski wrote:
> On 2011/11/21 19:45:21, I haz the power (commit-bot) wrote:
> > Can't apply patch for file build/android/run_tests.py.
> > While running patch -p1 --forward --force;
> > patching file build/android/run_tests.py
> > Hunk #1 FAILED at 50.
> > Hunk #2 succeeded at 111 with fuzz 2 (offset 48 lines).
> > Hunk #3 succeeded at 239 with fuzz 2 (offset 52 lines).
> > Hunk #4 FAILED at 210.
> > Hunk #5 FAILED at 246.
> > 3 out of 5 hunks FAILED -- saving rejects to file
> build/android/run_tests.py.rej
> 
> Sigh... I ctrl-c'd a dcommit which landed but didn't update rietveld.

Landed as http://src.chromium.org/viewvc/chrome?view=rev&revision=110982