Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 8536048: Make power button in status view invisible until we are sure battery is supported on device. (Closed)

Created:
9 years, 1 month ago by tbarzic
Modified:
9 years, 1 month ago
Reviewers:
achuithb, DaveMoore
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Make power button in status view invisible until we are sure battery is supported on device. BUG=chromium-os:21360 TEST=Verified power button is visible on Cr48 Verified power button is invisible when there is no battery Verified power button is invisible in vm PowerMenuButtonBrowserTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110560

Patch Set 1 #

Patch Set 2 : a #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -21 lines) Patch
M chrome/browser/chromeos/status/power_menu_button.cc View 1 4 chunks +18 lines, -20 lines 1 comment Download
M chrome/browser/chromeos/status/power_menu_button_browsertest.cc View 2 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tbarzic
Dave, could you take a look at this?
9 years, 1 month ago (2011-11-15 01:25:26 UTC) #1
achuithb
9 years, 1 month ago (2011-11-16 19:50:19 UTC) #2
DaveMoore
lgtm if you remove the string resource. http://codereview.chromium.org/8536048/diff/2001/chrome/browser/chromeos/status/power_menu_button.cc File chrome/browser/chromeos/status/power_menu_button.cc (left): http://codereview.chromium.org/8536048/diff/2001/chrome/browser/chromeos/status/power_menu_button.cc#oldcode340 chrome/browser/chromeos/status/power_menu_button.cc:340: tooltip_text = ...
9 years, 1 month ago (2011-11-16 23:35:27 UTC) #3
tbarzic
On 2011/11/16 23:35:27, DaveMoore wrote: > lgtm if you remove the string resource. > > ...
9 years, 1 month ago (2011-11-16 23:56:49 UTC) #4
achuithb
9 years, 1 month ago (2011-11-17 09:39:40 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698