Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 8536045: Make command buffer free transfer buffer when switching tabs (Closed)

Created:
9 years, 1 month ago by greggman
Modified:
9 years ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, jam, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Make command buffer free transfer buffer when switching tabs Note: another CL will attempt to free the command buffer as well. Also note: I didn't want to change the function signature of GLES2Implementation as that would have been a much larger change. So, the startup code in renderer_gl_context.cc still creates the initial transfer buffer and info about that is passed into GLES2Implementation. A cleaner approach would probably have been to let GLES2Implemetation allocate the initial buffer but that's a much larger change. TEST=unit tests and ran Chrome testing a few pages and stepping in debugger. BUG=103989 R=apatrick@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112393

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fixed destructor issue #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+512 lines, -242 lines) Patch
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 2 3 4 6 chunks +88 lines, -39 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 3 4 42 chunks +203 lines, -99 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 2 3 4 19 chunks +20 lines, -19 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 2 3 4 7 chunks +196 lines, -81 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
greggman
hey al, please review when you get a chance
9 years, 1 month ago (2011-11-17 19:09:03 UTC) #1
greggman
ping
9 years, 1 month ago (2011-11-18 18:01:13 UTC) #2
apatrick_chromium
Sorry, thought I LGTMed whis already. LGTM.
9 years, 1 month ago (2011-11-18 18:02:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/8536045/14001
9 years, 1 month ago (2011-11-18 18:48:06 UTC) #4
commit-bot: I haz the power
Try job failure for 8536045-14001 (retry) on linux_rel for step "ui_tests". It's a second try, ...
9 years, 1 month ago (2011-11-18 20:09:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/8536045/14001
9 years ago (2011-11-29 17:50:44 UTC) #6
commit-bot: I haz the power
Can't apply patch for file gpu/command_buffer/client/gles2_implementation.cc. While running patch -p1 --forward --force; patching file gpu/command_buffer/client/gles2_implementation.cc ...
9 years ago (2011-11-29 17:50:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/8536045/23001
9 years ago (2011-12-01 01:14:43 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-01 04:25:36 UTC) #9
Change committed as 112393

Powered by Google App Engine
This is Rietveld 408576698