Extension state made per-siolate in genesis

src/isolate.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 41 matching lines @@
 class CodeRange;
 class CompilationCache;
 class ContextSlotCache;
 class ContextSwitcher;
 class Counters;
 class CpuFeatures;
 class CpuProfiler;
 class DeoptimizerData;
 class Deserializer;
 class EmptyStatement;
+class ExtensionStates;
 class ExternalReferenceTable;
 class Factory;
 class FunctionInfoListener;
 class HandleScopeImplementer;
 class HeapProfiler;
 class InlineRuntimeFunctionsTable;
 class NoAllocationStringAllocator;
 class InnerPointerToCodeCache;
 class PreallocatedMemoryThread;
 class RegExpStack;
@@ skipping 731 matching lines @@
     ASSERT(logger_ != NULL);
     return logger_;
   }
   StackGuard* stack_guard() { return &stack_guard_; }
   Heap* heap() { return &heap_; }
   StatsTable* stats_table();
   StubCache* stub_cache() { return stub_cache_; }
   DeoptimizerData* deoptimizer_data() { return deoptimizer_data_; }
   ThreadLocalTop* thread_local_top() { return &thread_local_top_; }
 
+  ExtensionStates* extension_states() { return extension_states_; }

[Vitaly Repeshko, 2011/11/15 18:14:17]

It's really unfortunate that this is a part of the isolate state. Please explore
a slightly different approach. Make the InstallExtension family of functions
instance (instead of static) methods of Genesis and move all the extension state
tracking code there. To support the assert in serialize.cc a simple bool flag in
Bootstrapper (e.g. "have_installed_extensions") should be enough.

+
   TranscendentalCache* transcendental_cache() const {
     return transcendental_cache_;
   }
 
   MemoryAllocator* memory_allocator() {
     return memory_allocator_;
   }
 
   KeyedLookupCache* keyed_lookup_cache() {
     return keyed_lookup_cache_;
@@ skipping 297 matching lines @@
   Bootstrapper* bootstrapper_;
   RuntimeProfiler* runtime_profiler_;
   CompilationCache* compilation_cache_;
   Counters* counters_;
   CodeRange* code_range_;
   Mutex* break_access_;
   Atomic32 debugger_initialized_;
   Mutex* debugger_access_;
   Heap heap_;
   Logger* logger_;
+  ExtensionStates* extension_states_;
   StackGuard stack_guard_;
   StatsTable* stats_table_;
   StubCache* stub_cache_;
   DeoptimizerData* deoptimizer_data_;
   ThreadLocalTop thread_local_top_;
   bool capture_stack_trace_for_uncaught_exceptions_;
   int stack_trace_for_uncaught_exceptions_frame_limit_;
   StackTrace::StackTraceOptions stack_trace_for_uncaught_exceptions_options_;
   TranscendentalCache* transcendental_cache_;
   MemoryAllocator* memory_allocator_;
@@ skipping 219 matching lines @@
 
 // Mark the global context with out of memory.
 inline void Context::mark_out_of_memory() {
   global_context()->set_out_of_memory(HEAP->true_value());
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_ISOLATE_H_