Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4584)

Unified Diff: chrome/browser/download/download_safe_browsing_client_unittest.cc

Issue 8536041: This CL integrates the new SafeBrowsing download service class (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fix uninitialized variable issue. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_safe_browsing_client_unittest.cc
diff --git a/chrome/browser/download/download_safe_browsing_client_unittest.cc b/chrome/browser/download/download_safe_browsing_client_unittest.cc
deleted file mode 100644
index 9dc47e3fb0371a05697f88d878156fd914d5f427..0000000000000000000000000000000000000000
--- a/chrome/browser/download/download_safe_browsing_client_unittest.cc
+++ /dev/null
@@ -1,91 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/message_loop.h"
-#include "chrome/browser/download/download_safe_browsing_client.h"
-#include "chrome/browser/safe_browsing/safe_browsing_service.h"
-#include "content/test/test_browser_thread.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using content::BrowserThread;
-
-namespace {
-
-const char* kUrl1 = "http://127.0.0.1/";
-const char* kUrl2 = "http://127.0.0.1/two";
-const char* kUrl3 = "http://127.0.0.1/three";
-const char* kRefUrl = "http://127.0.0.1/referrer";
-
-class MockSafeBrowsingService : public SafeBrowsingService {
- public:
- MockSafeBrowsingService() {}
- virtual ~MockSafeBrowsingService() {}
-
- MOCK_METHOD6(ReportSafeBrowsingHit,
- void(const GURL&, const GURL&, const GURL&, bool, UrlCheckResult,
- const std::string&));
-
- private:
- DISALLOW_COPY_AND_ASSIGN(MockSafeBrowsingService);
-};
-
-} // namespace
-
-class DownloadSBClientTest : public testing::Test {
- public:
- DownloadSBClientTest() :
- ui_thread_(BrowserThread::UI, &loop_) {
- }
-
- private:
- MessageLoop loop_;
-
- // UI thread to satisfy debug checks in DownloadSBClient.
- content::TestBrowserThread ui_thread_;
-};
-
-TEST_F(DownloadSBClientTest, UrlHit) {
- std::string expected_post =
- std::string(kUrl1) + "\n" + kUrl2 + "\n" + kUrl3 + "\n";
- scoped_refptr<MockSafeBrowsingService> sb_service(
- new MockSafeBrowsingService);
- EXPECT_CALL(*sb_service.get(),
- ReportSafeBrowsingHit(GURL(kUrl3), GURL(kUrl1), GURL(kRefUrl), true,
- SafeBrowsingService::BINARY_MALWARE_URL,
- expected_post));
- std::vector<GURL> url_chain;
- url_chain.push_back(GURL(kUrl1));
- url_chain.push_back(GURL(kUrl2));
- url_chain.push_back(GURL(kUrl3));
-
- scoped_refptr<DownloadSBClient> client(
- new DownloadSBClient(1, url_chain, GURL(kRefUrl), true));
- client->SetSBService(sb_service.get());
-
- client->ReportMalware(SafeBrowsingService::BINARY_MALWARE_URL, "");
-}
-
-TEST_F(DownloadSBClientTest, DigestHit) {
- std::string hash_data = "\xDE\xAD\xBE\xEF";
- std::string hash_string = "DEADBEEF";
- std::string expected_post =
- hash_string + "\n" + kUrl1 + "\n" + kUrl2 + "\n" + kUrl3 + "\n";
- scoped_refptr<MockSafeBrowsingService> sb_service(
- new MockSafeBrowsingService);
- EXPECT_CALL(*sb_service.get(),
- ReportSafeBrowsingHit(GURL(kUrl3), GURL(kUrl1), GURL(kRefUrl), true,
- SafeBrowsingService::BINARY_MALWARE_HASH,
- expected_post));
- std::vector<GURL> url_chain;
- url_chain.push_back(GURL(kUrl1));
- url_chain.push_back(GURL(kUrl2));
- url_chain.push_back(GURL(kUrl3));
-
- scoped_refptr<DownloadSBClient> client(
- new DownloadSBClient(1, url_chain, GURL(kRefUrl), true));
- client->SetSBService(sb_service.get());
-
- client->ReportMalware(SafeBrowsingService::BINARY_MALWARE_HASH, hash_data);
-}

Powered by Google App Engine
This is Rietveld 408576698