Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6280)

Unified Diff: chrome_frame/crash_reporting/nt_loader_unittest.cc

Issue 8536037: base::Bind: Low-hanging fruit conversions of NewRunnableFunction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win fix 4. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/service/cloud_print/cloud_print_proxy.cc ('k') | chrome_frame/test/net/fake_external_tab.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/crash_reporting/nt_loader_unittest.cc
diff --git a/chrome_frame/crash_reporting/nt_loader_unittest.cc b/chrome_frame/crash_reporting/nt_loader_unittest.cc
index 4f75d7424357df50e8a3364b41f20430342655ea..3bc27bf9d3434aefcf1485d9314d7f8b5c6e14d8 100644
--- a/chrome_frame/crash_reporting/nt_loader_unittest.cc
+++ b/chrome_frame/crash_reporting/nt_loader_unittest.cc
@@ -8,6 +8,8 @@
#include <winnt.h>
#include "base/at_exit.h"
+#include "base/bind.h"
+#include "base/bind_helpers.h"
#include "base/environment.h"
#include "base/memory/scoped_ptr.h"
#include "base/message_loop.h"
@@ -81,11 +83,11 @@ TEST(NtLoader, OwnsCriticalSection) {
base::Thread other("Other threads");
ASSERT_TRUE(other.Start());
other.message_loop()->PostTask(
- FROM_HERE, NewRunnableFunction(::EnterCriticalSection, &cs));
+ FROM_HERE, base::Bind(::EnterCriticalSection, &cs));
base::win::ScopedHandle event(::CreateEvent(NULL, FALSE, FALSE, NULL));
other.message_loop()->PostTask(
- FROM_HERE, NewRunnableFunction(::SetEvent, event.Get()));
+ FROM_HERE, base::IgnoreReturn<BOOL>(base::Bind(::SetEvent, event.Get())));
ASSERT_EQ(WAIT_OBJECT_0, ::WaitForSingleObject(event.Get(), INFINITE));
@@ -96,7 +98,7 @@ TEST(NtLoader, OwnsCriticalSection) {
// Make the other thread release it.
other.message_loop()->PostTask(
- FROM_HERE, NewRunnableFunction(::LeaveCriticalSection, &cs));
+ FROM_HERE, base::Bind(::LeaveCriticalSection, &cs));
other.Stop();
« no previous file with comments | « chrome/service/cloud_print/cloud_print_proxy.cc ('k') | chrome_frame/test/net/fake_external_tab.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698