Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 8536036: Devirtualize CHROMEGTK_CALLBACK. (Closed)

Created:
9 years, 1 month ago by dcheng
Modified:
9 years, 1 month ago
CC:
chromium-reviews, asanka, Avi (use Gerrit), creis+watch_chromium.org, tfarina, Erik does not do reviews, ajwong+watch_chromium.org, jam, Randy Smith (Not in Mondays), mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org, dpranke-watch+content_chromium.org, dhollowa
Visibility:
Public.

Description

Devirtualize CHROMEGTK_CALLBACK. BUG=103827 TEST=compiles on clang without warnings and passes tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109784

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -68 lines) Patch
M chrome/browser/ui/gtk/avatar_menu_button_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/crypto_module_password_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_in_progress_dialog_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/edit_search_engine_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/external_protocol_dialog_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/importer/import_lock_dialog_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/instant_confirm_dialog_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/menu_bar_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/sad_tab_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/update_recommended_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/web_drag_dest_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/gtk/gtk_signal.h View 1 chunk +37 lines, -10 lines 0 comments Download
M ui/base/gtk/tooltip_window_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M views/widget/native_widget_gtk.h View 1 chunk +54 lines, -44 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcheng
Same thing, but for CHROMEGTK_CALLBACK. One thing I noticed is that most of NativeWidgetGtk doesn't ...
9 years, 1 month ago (2011-11-11 23:04:26 UTC) #1
dcheng
Same thing, but for CHROMEGTK_CALLBACK. One thing I noticed is that most of NativeWidgetGtk doesn't ...
9 years, 1 month ago (2011-11-11 23:04:27 UTC) #2
Elliot Glaysher
On 2011/11/11 23:04:27, dcheng wrote: > Same thing, but for CHROMEGTK_CALLBACK. > > One thing ...
9 years, 1 month ago (2011-11-11 23:26:44 UTC) #3
Evan Stade
lgtm
9 years, 1 month ago (2011-11-12 00:07:31 UTC) #4
dcheng
Adding sky for OWNERS review for content/browser/*, ui/base/*, and views/*. I'm not going to submit ...
9 years, 1 month ago (2011-11-12 00:11:37 UTC) #5
sky
9 years, 1 month ago (2011-11-12 00:46:12 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698