Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 8536035: Include the full certificate chain in the download pingback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/safe_browsing/csd.proto
===================================================================
--- chrome/common/safe_browsing/csd.proto (revision 109680)
+++ chrome/common/safe_browsing/csd.proto (working copy)
@@ -124,10 +124,24 @@
// triggered the download) as well as for the download URL itself.
repeated Resource resources = 4;
+ // A trust chain of certificates. Each chain begins with the signing
+ // certificate of the binary, and ends with a self-signed certificate,
+ // typically from a trusted root CA. This structure is analogous to
+ // CERT_CHAIN_CONTEXT on Windows.
+ message CertificateChain {
+ // A single link in the chain.
+ message Element {
+ // DER-encoded X.509 representation of the certificate.
+ optional bytes certificate = 1;
+ }
+ repeated Element element = 1;
+ }
+
message SignatureInfo {
- // The full DER-encoded X.509 certificate extracted from the binary.
- // If this field is not present, it means the binary was unsigned.
- optional bytes certificate_contents = 1;
+ // All of the certificate chains for the binary's signing certificate.
+ // If no chains are present, the binary is not signed. Multiple chains
+ // may be present if any certificate has multiple signers.
+ repeated CertificateChain certificate_chain = 1;
// True if the signature was trusted on the client.
optional bool trusted = 2;

Powered by Google App Engine
This is Rietveld 408576698