Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issue 8536031: Reland http://codereview.chromium.org/8477015 (Closed)

Created:
9 years, 1 month ago by dmichael (off chromium)
Modified:
9 years, 1 month ago
Reviewers:
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Reland http://codereview.chromium.org/8477015 Landed at r109114, Reverted at r109142 Make it possible to enable/disable specific ppapi tests. Migrate PostMessage tests. The testcase attribute now can include a 'filter'. If it's omitted, everything works the same as before. This way we can migrate tests over bit-by-bit if we want to. We can also still run the tests manually the same way as before. This only runs PostMessage testss the new way, and re-enables all oop PostMessage tests that pass on Windows. I can do the other tests in this CL if desired, but it might be easier to land in a few pieces. BUG=102885 TEST=N/A TBR=dmichael@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110248

Patch Set 1 #

Patch Set 2 : Merged. #

Patch Set 3 : Merge, keep the tests disabled on valgrind #

Patch Set 4 : merge #

Patch Set 5 : merge AGAIN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -235 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 2 3 4 1 chunk +11 lines, -2 lines 0 comments Download
M ppapi/tests/test_broker.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_broker.cc View 1 2 3 4 1 chunk +6 lines, -5 lines 0 comments Download
M ppapi/tests/test_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_case.h View 3 chunks +19 lines, -12 lines 0 comments Download
M ppapi/tests/test_case.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ppapi/tests/test_char_set.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_char_set.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/tests/test_core.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_core.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/tests/test_crypto.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_crypto.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_cursor_control.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_cursor_control.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/tests/test_directory_reader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_directory_reader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_file_io.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_file_io.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M ppapi/tests/test_file_ref.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_file_ref.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M ppapi/tests/test_file_system.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_file_system.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/tests/test_flash_clipboard.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_flash_clipboard.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_flash_fullscreen.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_flash_fullscreen.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/tests/test_fullscreen.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_fullscreen.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/tests/test_graphics_2d.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_graphics_2d.cc View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M ppapi/tests/test_graphics_3d.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_graphics_3d.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_image_data.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_image_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_instance_deprecated.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_instance_deprecated.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/tests/test_memory.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_memory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/tests/test_net_address_private.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_net_address_private.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M ppapi/tests/test_paint_aggregator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_paint_aggregator.cc View 2 chunks +22 lines, -22 lines 0 comments Download
M ppapi/tests/test_post_message.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_post_message.cc View 6 chunks +19 lines, -13 lines 0 comments Download
M ppapi/tests/test_scrollbar.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_scrollbar.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_tcp_socket_private.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_tcp_socket_private.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/tests/test_transport.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_transport.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M ppapi/tests/test_uma.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_uma.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/tests/test_url_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_url_loader.cc View 1 2 3 4 1 chunk +21 lines, -21 lines 0 comments Download
M ppapi/tests/test_url_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_url_util.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M ppapi/tests/test_var.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_var.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M ppapi/tests/test_var_deprecated.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_var_deprecated.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M ppapi/tests/test_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_video_decoder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/tests/testing_instance.h View 2 chunks +16 lines, -2 lines 0 comments Download
M ppapi/tests/testing_instance.cc View 3 chunks +12 lines, -3 lines 0 comments Download
M tools/valgrind/gtest_exclude/ui_tests.gtest.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/gtest_exclude/ui_tests.gtest_mac.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
No reviewers yet.
9 years, 1 month ago (2011-11-15 23:29:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/8536031/8001
9 years, 1 month ago (2011-11-15 23:32:58 UTC) #2
commit-bot: I haz the power
9 years, 1 month ago (2011-11-16 00:52:18 UTC) #3
Can't apply patch for file ppapi/tests/test_url_loader.cc.
While running patch -p1 --forward --force;
patching file ppapi/tests/test_url_loader.cc
Hunk #1 FAILED at 77.
1 out of 1 hunk FAILED -- saving rejects to file
ppapi/tests/test_url_loader.cc.rej

Powered by Google App Engine
This is Rietveld 408576698