Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Unified Diff: chrome/browser/ui/app_modal_dialogs/message_box_handler.cc

Issue 8536026: Convert MessageBoxFlags class into an enum. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_modal_dialogs/message_box_handler.cc
diff --git a/chrome/browser/ui/app_modal_dialogs/message_box_handler.cc b/chrome/browser/ui/app_modal_dialogs/message_box_handler.cc
index 9dc374a865920d655aa5a567e003ff8f8b0bba00..32271d216ade8fae4ecd517a3bb40e728d2dc365 100644
--- a/chrome/browser/ui/app_modal_dialogs/message_box_handler.cc
+++ b/chrome/browser/ui/app_modal_dialogs/message_box_handler.cc
@@ -7,9 +7,9 @@
#include <map>
#include "base/compiler_specific.h"
+#include "base/i18n/rtl.h"
#include "base/memory/singleton.h"
#include "base/utf_string_conversions.h"
-#include "base/i18n/rtl.h"
#include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h"
#include "chrome/browser/ui/app_modal_dialogs/js_modal_dialog.h"
#include "chrome/common/chrome_constants.h"
@@ -101,7 +101,7 @@ void ChromeJavaScriptDialogCreator::RunJavaScriptDialog(
display_suppress_checkbox = true;
}
- bool is_alert = dialog_flags == ui::MessageBoxFlags::kIsJavascriptAlert;
+ bool is_alert = dialog_flags == ui::MESSAGE_BOX_IS_JAVASCRIPT_ALERT_DIALOG;
string16 dialog_title = GetTitle(title_type, title, is_alert);
AppModalDialogQueue::GetInstance()->AddDialog(new JavaScriptAppModalDialog(
@@ -130,7 +130,7 @@ void ChromeJavaScriptDialogCreator::RunBeforeUnloadDialog(
delegate,
extra_data,
l10n_util::GetStringUTF16(IDS_BEFOREUNLOAD_MESSAGEBOX_TITLE),
- ui::MessageBoxFlags::kIsJavascriptConfirm,
+ ui::MESSAGE_BOX_IS_JAVASCRIPT_CONFIRM_DIALOG,
full_message,
string16(), // default_prompt_text
false, // display_suppress_checkbox

Powered by Google App Engine
This is Rietveld 408576698