Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8536010: Cleanup: Remove unneeded forward declarations from chrome/browser/ui/gtk and chrome/browser/ui/co... (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
CC:
chromium-reviews, asanka, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Randy Smith (Not in Mondays)
Visibility:
Public.

Description

Cleanup: Remove unneeded forward declarations from chrome/browser/ui/gtk and chrome/browser/ui/cocoa. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110048

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 10

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -69 lines) Patch
M chrome/browser/ui/cocoa/content_settings/cookie_details.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_mac.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.h View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/extension_infobar_controller.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/mock_link_infobar_delegate.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_base.h View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/instant_opt_in_controller.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_view_host_mac.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/web_intent_bubble_controller.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.h View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/download/download_item_gtk.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/find_bar_gtk.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/html_dialog_gtk.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/reload_button_gtk.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_contents_container_gtk.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_gtk.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/web_intent_picker_gtk.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
GTK if your name starts with 'e'.
9 years, 1 month ago (2011-11-11 10:16:08 UTC) #1
Mark Mentovai
Needs more completeness! I only reviewed the cocoa files. You (or someone) should make a ...
9 years, 1 month ago (2011-11-11 17:19:35 UTC) #2
Lei Zhang
I make no claim that my 10 line script is perfect. It handles the 95% ...
9 years, 1 month ago (2011-11-11 21:05:19 UTC) #3
Mark Mentovai
LGTM in cocoa. Didn’t realize you scripted this. I figured you might have just gotten ...
9 years, 1 month ago (2011-11-11 21:07:23 UTC) #4
Elliot Glaysher
lgtm gtk
9 years, 1 month ago (2011-11-11 22:17:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8536010/3008
9 years, 1 month ago (2011-11-12 15:49:41 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-12 18:14:33 UTC) #7 
Try job failure for 8536010-3008 (retry) on mac_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698