Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 8536009: Fix filtering of store buffer for large object pages. (Closed)

Created:
9 years, 1 month ago by Michael Starzinger
Modified:
9 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Fix filtering of store buffer for large object pages. Our Heap::FreeQueuedChunks generates fake inner chunks in large object pages queued for freeing, so that StoreBuffer::Filter can recognize them as pages to be freed. This also relies on MemoryChunk::Contains to work properly, which is why the size field needs to be initialized as well. R=vegorov@chromium.org BUG=v8:1817 TEST=mozilla/js1_5/Regress/regress-360969-05 Committed: http://code.google.com/p/v8/source/detail?r=9964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M src/heap.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/spaces.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mozilla/mozilla.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
PTAL.
9 years, 1 month ago (2011-11-11 09:20:22 UTC) #1
Erik Corry
9 years, 1 month ago (2011-11-11 09:22:59 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698