Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: chrome/test/perf/frame_rate/frame_rate_tests.cc

Issue 8536008: Use only the steady gesture in frame rate tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: typo removal. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/perf/frame_rate/head.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/perf/frame_rate/frame_rate_tests.cc
diff --git a/chrome/test/perf/frame_rate/frame_rate_tests.cc b/chrome/test/perf/frame_rate/frame_rate_tests.cc
index 99d40622e257dd4476e09e46c3cee961bf2d7193..1e5f017fb761d7b91e0f0f89488167c94c136d94 100644
--- a/chrome/test/perf/frame_rate/frame_rate_tests.cc
+++ b/chrome/test/perf/frame_rate/frame_rate_tests.cc
@@ -84,6 +84,12 @@ class FrameRateTest
if (HasFlag(kUseReferenceBuild))
UseReferenceBuild();
+ // Turn on chrome.Interval to get higher-resolution timestamps on frames.
+ launch_arguments_.AppendSwitch(switches::kEnableBenchmarking);
+
+ // Required additional argument to make the kEnableBenchmarking switch work.
+ launch_arguments_.AppendSwitch(switches::kEnableStatsTable);
+
// UI tests boot up render views starting from about:blank. This causes
// the renderer to start up thinking it cannot use the GPU. To work
// around that, and allow the frame rate test to use the GPU, we must
@@ -132,7 +138,8 @@ class FrameRateTest
void RunTest(const std::string& name) {
if (HasFlag(kUseGpu) && !IsGpuAvailable()) {
- printf("Test skipped: requires gpu\n");
+ printf("Test skipped: requires gpu. Pass --enable-gpu on the command "
+ "line if use of GPU is desired.\n");
return;
}
@@ -218,7 +225,7 @@ class FrameRateTest
ASSERT_TRUE(results.find("means") != results.end());
ASSERT_TRUE(results.find("sigmas") != results.end());
- std::string trace_name = "fps" + GetSuffixForTestFlags();
+ std::string trace_name = "interval" + GetSuffixForTestFlags();
printf("GESTURES %s: %s= [%s] [%s] [%s]\n", name.c_str(),
trace_name.c_str(),
results["gestures"].c_str(),
« no previous file with comments | « chrome/test/data/perf/frame_rate/head.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698