Issue 8536007: dbus: Add ObjectProxy::EmptyResponseCallback().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8536007: dbus: Add ObjectProxy::EmptyResponseCallback(). (Closed)

Created:
9 years, 1 month ago by satorux1

Modified:
9 years, 1 month ago

Reviewers:
hashimoto, Simon Que

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

dbus: Add ObjectProxy::EmptyResponseCallback(). This can be used when the caller is not interested in the response from the D-bus method. BUG=none TEST=added a unit test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109598

Patch Set 1 #

Patch Set 2 : cleanup #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -4 lines)			Patch
M	dbus/end_to_end_async_unittest.cc	View	1	2 chunks	+23 lines, -0 lines	0 comments	Download
M	dbus/object_proxy.h	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	dbus/object_proxy.cc	View		4 chunks	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hashimoto

LGTM. BTW, is it possible to make constants to replace literals like "org.chromium.TestInterface"? The current ...

9 years, 1 month ago (2011-11-11 07:15:12 UTC) #2

satorux1

On 2011/11/11 07:15:12, hashimoto wrote: > LGTM. > > BTW, is it possible to make ...

9 years, 1 month ago (2011-11-11 07:30:47 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/8536007/1001

9 years, 1 month ago (2011-11-11 07:31:27 UTC) #4

Change committed as 109598

Expand Messages | Collapse Messages