Issue 8536004: Cleanup: Remove unneeded forward declarations in views.

Issue 8536004: Cleanup: Remove unneeded forward declarations in views. (Closed)

Created:
9 years, 1 month ago by Lei Zhang

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, James Su, dhollowa

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Cleanup: Remove unneeded forward declarations in views. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110047

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -37 lines)			Patch
M	views/controls/menu/menu_host.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	views/controls/menu/menu_item_view.h	View	1 2	2 chunks	+3 lines, -7 lines	0 comments	Download
M	views/controls/menu/native_menu_host.h	View	1 2	1 chunk	+2 lines, -4 lines	0 comments	Download
M	views/controls/menu/native_menu_host_delegate.h	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	views/controls/scrollbar/native_scroll_bar_gtk.h	View	1 2	3 chunks	+2 lines, -5 lines	0 comments	Download
M	views/controls/table/table_view.h	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	views/controls/textfield/textfield_views_model.h	View	1 2	2 chunks	+0 lines, -4 lines	0 comments	Download
M	views/desktop/desktop_window_view.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	views/native_theme_painter.h	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download
M	views/view.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	views/widget/native_widget_gtk.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	views/widget/native_widget_test_utils.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	views/widget/native_widget_wayland.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	views/widget/widget.h	View	1 2	4 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8536004/1

9 years, 1 month ago (2011-11-11 22:37:08 UTC) #3

commit-bot: I haz the power

Can't apply patch for file views/view.h. While running patch -p0 --forward --force; patching file views/view.h ...

9 years, 1 month ago (2011-11-11 22:37:13 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8536004/4003

9 years, 1 month ago (2011-11-11 22:43:14 UTC) #5

commit-bot: I haz the power

9 years, 1 month ago (2011-11-12 01:23:38 UTC) #6

Try job failure for 8536004-4003 (retry) (previous was lost) on mac_rel for step
"ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Expand Messages | Collapse Messages