Pointer Lock (was Mouse Lock) added to about:flags and passed to WebKit runtime flags

Pointer lock added to about:flags and passed to WebKit runtime flags


BUG=72754
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110632

[scheib, 2011-11-17 01:14:13]

avi, jam, tony: OWNERS review please.

[jam, 2011-11-17 01:19:03]

content lgtm

[tony, 2011-11-17 01:25:48]

webkit/glue LGTM

http://codereview.chromium.org/8536003/diff/2001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8536003/diff/2001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:4884: When enabled, web pages may capture the
mouse pointer and remove it from the user's control. The mouse movement data is
directed soly to the web application. Users can escape by pressing the 'ESC'
key.
Nit: soly -> solely, ESC -> Esc (at least, on my keyboard it's Esc and Apple
keyboards appear to use esc).

[scheib, 2011-11-17 23:04:38]

Spelling nit fixed.

Also, a trimmed down patch is coming -- I don't need per page settings with this
flag. All remaining files are untouched.

http://codereview.chromium.org/8536003/diff/2001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8536003/diff/2001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:4884: When enabled, web pages may capture the
mouse pointer and remove it from the user's control. The mouse movement data is
directed soly to the web application. Users can escape by pressing the 'ESC'
key.
On 2011/11/17 01:25:49, tony wrote:
> Nit: soly -> solely, ESC -> Esc (at least, on my keyboard it's Esc and Apple
> keyboards appear to use esc).

Done.

[commit-bot: I haz the power, 2011-11-17 23:06:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scheib@chromium.org/8536003/2003

[commit-bot: I haz the power, 2011-11-18 00:38:57]

Can't apply patch for file
content/browser/renderer_host/browser_render_process_host.cc.
While running patch -p1 --forward --force;
patching file content/browser/renderer_host/browser_render_process_host.cc
Hunk #1 FAILED at 579.
1 out of 1 hunk FAILED -- saving rejects to file
content/browser/renderer_host/browser_render_process_host.cc.rej

[commit-bot: I haz the power, 2011-11-18 00:47:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scheib@chromium.org/8536003/9001

[commit-bot: I haz the power, 2011-11-18 01:50:26]

Change committed as 110632