Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8536002: Cleanup: Remove unneeded forward declarations from remoting. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
Reviewers:
awong, Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Remove unneeded forward declarations from remoting. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109593

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -135 lines) Patch
M remoting/base/encoder_row_based.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M remoting/client/chromoting_client.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/client/chromoting_view.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M remoting/client/frame_consumer.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.h View 1 2 3 chunks +1 line, -9 lines 0 comments Download
M remoting/client/plugin/pepper_view_proxy.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M remoting/client/rectangle_update_decoder.h View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M remoting/host/chromoting_host.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M remoting/host/chromoting_host_context.h View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M remoting/host/disconnect_window_mac.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/host_config.h View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M remoting/host/host_status_observer.h View 1 2 2 chunks +3 lines, -7 lines 0 comments Download
M remoting/host/in_memory_host_config.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/json_host_config.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/plugin/host_script_object.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/host/register_support_host_request.h View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M remoting/host/support_access_verifier.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/jingle_glue/jingle_thread.h View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M remoting/jingle_glue/xmpp_proxy.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M remoting/protocol/buffered_socket_writer.h View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M remoting/protocol/client_control_sender.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M remoting/protocol/client_message_dispatcher.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/protocol/connection_to_host.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/protocol/host_message_dispatcher.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/protocol/host_stub.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/protocol/input_stub.h View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M remoting/protocol/jingle_datagram_connector.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/protocol/jingle_stream_connector.h View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M remoting/protocol/pepper_session.h View 1 2 4 chunks +2 lines, -9 lines 0 comments Download
M remoting/protocol/pepper_stream_channel.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M remoting/protocol/pepper_transport_socket_adapter.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/protocol_mock_objects.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/rtcp_writer.h View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M remoting/protocol/session.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/protocol/session_manager.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/protocol/util.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M remoting/protocol/video_reader.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
9 years, 1 month ago (2011-11-11 02:55:06 UTC) #1
Wez
LGTM - Thanks!
9 years, 1 month ago (2011-11-11 04:10:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8536002/5006
9 years, 1 month ago (2011-11-11 05:17:40 UTC) #3
commit-bot: I haz the power
Can't apply patch for file remoting/host/host_status_observer.h. While running patch -p0 --forward --force; patching file remoting/host/host_status_observer.h ...
9 years, 1 month ago (2011-11-11 05:17:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8536002/5009
9 years, 1 month ago (2011-11-11 05:32:48 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-11 06:44:25 UTC) #6 
Change committed as 109593

Powered by Google App Engine
This is Rietveld 408576698