frog/lib/corelib_impl.dart - Issue 8534001: Adds typechecking of return values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/lib/corelib_impl.dart

Issue 8534001: Adds typechecking of return values (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merged Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: frog/lib/corelib_impl.dart

diff --git a/frog/lib/corelib_impl.dart b/frog/lib/corelib_impl.dart

index 3b249203ac22a781baa6a88a2f1e21d264f37bc8..e08e38c59950532fc4da9255666a21dee20e270f 100644

--- a/frog/lib/corelib_impl.dart

+++ b/frog/lib/corelib_impl.dart

@@ -235,9 +235,9 @@ class JSSyntaxRegExp implements RegExp {

final bool multiLine;

final bool ignoreCase;

- const JSSyntaxRegExp(String pattern,

- [bool multiLine = false, bool ignoreCase = false]):

Siggi Cherem (dart-lang) 2011/11/11 08:23:53 why is this change needed?

- this._create(pattern, (multiLine ? 'm' : '') + (ignoreCase ? 'i' : ''));

+ const JSSyntaxRegExp(String pattern, [bool multiLine, bool ignoreCase]):

+ this._create(pattern,

jimhug 2011/11/11 15:02:02 I agree with Siggi that the previous version of th

Jennifer Messerly 2011/11/11 18:23:55 I commented on this here: http://codereview.chromi

+ (multiLine == true ? 'm' : '') + (ignoreCase == true ? 'i' : ''));

const JSSyntaxRegExp._create(String pattern, String flags) native

'''this.re = new RegExp(pattern, flags);